Skip to content

[BACK-4088] Bump go version to 1.25.x. #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lostlevels merged 1 commit into from
Apr 6, 2026
Merged

[BACK-4088] Bump go version to 1.25.x. #898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ dist: jammy
language: go

go:
- 1.24.5
- 1.25.7

services:
- docker
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG GOLANG_VERSION=1.24.5-alpine
ARG GOLANG_VERSION=1.25.7-alpine
ARG MONGO_VERSION=6.0.23
ARG PLUGIN_VISIBILITY=public

Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ ifdef PLUGIN
{ [ -e go.work ] || go work init .; } && \
go work edit -use=./private/plugin/$(PLUGIN) && \
go work edit -go=`sed -n 's/^go //p' go.mod` && \
go work edit -toolchain=`sed -n 's/^toolchain //p' go.mod` && \
go work edit -toolchain=`grep -q '^toolchain' go.mod && sed -n 's/^toolchain //p' go.mod || sed -n 's/^go /go/p' go.mod` && \
Copy link
Copy Markdown
Contributor

@darinkrauss darinkrauss Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - what is this change for?

Copy link
Copy Markdown
Contributor Author

@lostlevels lostlevels Mar 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go mod tidy for me removed the toolchain go... in the go.mod so the go work edit -toolchain= call would have an empty value causing the build to fail so this was added in case someone else's run of go mod tidy adds it back.

$(MAKE) plugin-visibility
endif

Expand Down
4 changes: 1 addition & 3 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module github.com/tidepool-org/platform

go 1.24.1

toolchain go1.24.5
go 1.25.7

require (
github.com/IBM/sarama v1.45.1
Expand Down
4 changes: 2 additions & 2 deletions plugin/abbott/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module github.com/tidepool-org/platform-plugin-abbott

go 1.24.1
go 1.25.7

toolchain go1.24.5
toolchain go1.25.7

require (
github.com/lestrrat-go/jwx/v2 v2.1.4
Expand Down
Loading