Add live trading capability for real Binance trading - #78
Open
qwldcl-del wants to merge 1 commit into
Open
Conversation
## Summary Implements real trading functionality as requested in bounty tiagosiebler#50. ## Changes - **TradingCore.js**: Added functions: - executeLiveTrade() - Execute real trades on Binance - calculateProfit() - Calculate potential profit for a path - setPaperOnly() - Toggle paper/live trading - setMinOrderAmount() - Configure minimum order amount - **BotCore.js**: Added trading event handlers for: - tradeCalculated - orderExecuted - tradeCompleted - tradeFailed - tradeSkipped - **conf.ini**: Added configuration: - paperTrading (default: true) - minOrderAmount (default: 0.001 BTC) - minProfitThreshold (default: 0.02%) - **index.js**: Updated to read trading config from environment ## Usage To enable live trading: 1. Set paperTrading=false in conf.ini 2. Add your Binance API keys to .keys file 3. Set minOrderAmount to desired trading amount ## Bounty Reference Implements: tiagosiebler#50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test PR to upstream