Emit input value on blur for input components#281
Merged
Conversation
Member
MelissaAutumn
left a comment
MelissaAutumn
left a comment
There was a problem hiding this comment.
Maybe we should send the current event instead. I'm afraid that if we start changing default event params we may shoot ourselves in the foot later when we copy and paste code for a native html element. 🤔
davinotdavid
requested changes
May 13, 2026
Contributor
davinotdavid
left a comment
davinotdavid
left a comment
There was a problem hiding this comment.
Thanks for the work so far and sorry for the bad issue description 😅!
I agree with @MelissaAutumn here. I ran into this while working on something else in thunderbird-accounts where I only needed the value but there might be cases where the whole event would be needed!
Collaborator
Author
|
Good thinking, thanks for the suggestion. I changed it to emit the actual event, I agree this is much better! |
davinotdavid
approved these changes
May 13, 2026
Contributor
davinotdavid
left a comment
davinotdavid
left a comment
There was a problem hiding this comment.
lgtm! thank you very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This change emits/forwards the blur event when blurring a
TextInput,TextAreaorSelectInputcomponent.Why?
Convenience. This makes the current input value available when listening for the blur event.
Limitations and Notes
The SelectInput tests currently miss cases for events. I was too stupid (or too tired) to make it work for now.
Applicable Issues
Closes #279
Screenshots
None