Add buildAvatarSpec utility and export avatar-related types and functions#35
Conversation
📝 WalkthroughWalkthroughAdds ChangesAvatar utility exports
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/browser/src/utils/buildAvatarSpec.ts (1)
36-38: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd focused serializer/parser tests.
Cover serialization with and without
bg, blank content, and round-tripping throughextractAvatarParamsFromUrito lock the public URI contract.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/browser/src/utils/buildAvatarSpec.ts` around lines 36 - 38, Add focused tests for buildAvatarSpec covering URIs with and without bg, blank content serialization, and round-tripping the generated URI through extractAvatarParamsFromUri. Assert the parsed parameters match the original AvatarParams to preserve the public URI contract.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/browser/src/utils/buildAvatarSpec.ts`:
- Around line 36-38: Add focused tests for buildAvatarSpec covering URIs with
and without bg, blank content serialization, and round-tripping the generated
URI through extractAvatarParamsFromUri. Assert the parsed parameters match the
original AvatarParams to preserve the public URI contract.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 314807de-43c4-439d-9dc4-22cd856f7785
📒 Files selected for processing (3)
packages/browser/src/index.tspackages/browser/src/utils/buildAvatarSpec.tspackages/react/src/index.ts
Purpose
$subject
Approach
N/A
Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks
Summary by CodeRabbit