Skip to content

Add support for embedded Avatars#14

Merged
brionmario merged 1 commit into
thunder-id:mainfrom
brionmario:avatars
Jul 21, 2026
Merged

Add support for embedded Avatars#14
brionmario merged 1 commit into
thunder-id:mainfrom
brionmario:avatars

Conversation

@brionmario

Copy link
Copy Markdown
Member

Purpose

Adds a logo package that resolves an application/user branding "logo spec" string into a renderable representation on Android: emoji:<glyph> glyphs, avatar:shape=...,variant=...,content=...,colors=...,bg=... generated avatars, or a bare image URL, mirroring the same spec used by the JS SDKs (see thunder-id/thunderid#4182).

Approach

  • LogoSpecParser recognizes and decomposes the emoji: and avatar: schemes from a spec string; anything else is left for the caller to treat as a plain URL.
  • AvatarSpecEnums defines AvatarShape (rounded/circle) and AvatarVariant (one_letter/two_letter/anonymous_animal/anonymous_entity), each parsed from the spec's wire-value strings with a safe default fallback.
  • AvatarContentDeriver fills in content from a fallback seed (e.g. a display name) when the spec itself doesn't carry one — initials for letter variants, a deterministic hashed pick into the curated icon set for the anonymous variants (AvatarMath holds the shared hash/palette/rotation logic).
  • AvatarGenerator natively renders the one_letter/two_letter gradient-swatch variants to a Bitmap (no SVG dependency), matching the JS implementation's palette and rotation formula.
  • LogoIconRegistry maps curated anonymous_animal/anonymous_entity content keys to bundled drawable resources (PNGs at mdpi/xhdpi/xxhdpi, generated from the same source SVGs as the JS SDK's curated icon set).
  • LogoResolver.resolve(spec, fallbackSeedText) ties it together into a single entry point returning a sealed ResolvedLogo (Emoji / Icon / Avatar / Url), so callers render whichever variant comes back without needing to know the spec grammar.
  • This PR adds the core resolution/generation logic and its bundled assets; no UI-layer (Compose) consumer is wired up here.

Related Issues

Related PRs

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.

Security checks

  • Followed secure coding standards in WSO2 Secure Coding Guidelines
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@brionmario, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 44f6af02-3ba7-4025-8f30-923fab239972

📥 Commits

Reviewing files that changed from the base of the PR and between b069ba4 and a0e0cfa.

⛔ Files ignored due to path filters (156)
  • src/main/res/drawable-mdpi/logo_icon_anonymous_capybara.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_chameleon.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_chinchilla.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_chipmunk.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_chupacabra.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_dingo.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_dinosaur.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_frog.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_giraffe.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_hedgehog.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_hippo.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_jackal.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_jackalope.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_mink.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_otter.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_platypus.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_quagga.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_raccoon.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_anonymous_skunk.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_anchor.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_antenna.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_anvil.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_arch.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_bridge.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_chevron.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_circuit_node.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_compass.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_cube.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_diamond.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_dome.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_gate.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_hexagon.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_key.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_lighthouse.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_lock.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_obelisk.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_octagon.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_orbit_ring.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_parallelogram.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_pavilion.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_pentagon.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_plus_facet.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_silo.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_spiral.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_spire.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_star.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_tower.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_townhouse.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_triangle_stack.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_turbine.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_valve.png is excluded by !**/*.png
  • src/main/res/drawable-mdpi/logo_icon_entity_windmill.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_capybara.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_chameleon.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_chinchilla.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_chipmunk.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_chupacabra.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_dingo.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_dinosaur.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_frog.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_giraffe.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_hedgehog.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_hippo.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_jackal.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_jackalope.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_mink.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_otter.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_platypus.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_quagga.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_raccoon.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_anonymous_skunk.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_anchor.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_antenna.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_anvil.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_arch.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_bridge.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_chevron.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_circuit_node.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_compass.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_cube.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_diamond.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_dome.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_gate.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_hexagon.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_key.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_lighthouse.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_lock.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_obelisk.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_octagon.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_orbit_ring.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_parallelogram.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_pavilion.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_pentagon.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_plus_facet.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_silo.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_spiral.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_spire.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_star.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_tower.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_townhouse.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_triangle_stack.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_turbine.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_valve.png is excluded by !**/*.png
  • src/main/res/drawable-xhdpi/logo_icon_entity_windmill.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_capybara.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_chameleon.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_chinchilla.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_chipmunk.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_chupacabra.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_dingo.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_dinosaur.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_frog.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_giraffe.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_hedgehog.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_hippo.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_jackal.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_jackalope.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_mink.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_otter.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_platypus.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_quagga.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_raccoon.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_anonymous_skunk.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_anchor.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_antenna.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_anvil.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_arch.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_bridge.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_chevron.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_circuit_node.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_compass.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_cube.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_diamond.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_dome.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_gate.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_hexagon.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_key.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_lighthouse.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_lock.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_obelisk.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_octagon.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_orbit_ring.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_parallelogram.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_pavilion.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_pentagon.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_plus_facet.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_silo.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_spiral.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_spire.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_star.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_tower.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_townhouse.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_triangle_stack.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_turbine.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_valve.png is excluded by !**/*.png
  • src/main/res/drawable-xxhdpi/logo_icon_entity_windmill.png is excluded by !**/*.png
📒 Files selected for processing (12)
  • src/main/kotlin/dev/thunderid/android/logo/AvatarContentDeriver.kt
  • src/main/kotlin/dev/thunderid/android/logo/AvatarGenerator.kt
  • src/main/kotlin/dev/thunderid/android/logo/AvatarMath.kt
  • src/main/kotlin/dev/thunderid/android/logo/AvatarSpecEnums.kt
  • src/main/kotlin/dev/thunderid/android/logo/LogoIconRegistry.kt
  • src/main/kotlin/dev/thunderid/android/logo/LogoResolver.kt
  • src/main/kotlin/dev/thunderid/android/logo/LogoSpecParser.kt
  • src/main/kotlin/dev/thunderid/android/logo/ResolvedLogo.kt
  • src/test/kotlin/dev/thunderid/android/logo/AvatarContentDeriverTest.kt
  • src/test/kotlin/dev/thunderid/android/logo/AvatarMathTest.kt
  • src/test/kotlin/dev/thunderid/android/logo/LogoResolverTest.kt
  • src/test/kotlin/dev/thunderid/android/logo/LogoSpecParserTest.kt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brionmario

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@brionmario
brionmario merged commit 9ce3139 into thunder-id:main Jul 21, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants