Skip to content

Color: Fix method return types to this #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Methuselah96 merged 1 commit into from
May 9, 2026
Merged

Color: Fix method return types to this #2144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions types/three/src/math/Color.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,16 +230,16 @@ export class Color {
*/
setFromVector3(vector: Vector3): this;

setScalar(scalar: number): Color;
setHex(hex: number, colorSpace?: string): Color;
setScalar(scalar: number): this;
setHex(hex: number, colorSpace?: string): this;

/**
* Sets this color from RGB values.
* @param r Red channel value between 0 and 1.
* @param g Green channel value between 0 and 1.
* @param b Blue channel value between 0 and 1.
*/
setRGB(r: number, g: number, b: number, colorSpace?: string): Color;
setRGB(r: number, g: number, b: number, colorSpace?: string): this;

/**
* Sets this color from HSL values.
Expand All @@ -249,20 +249,20 @@ export class Color {
* @param s Saturation value channel between 0 and 1.
* @param l Value channel value between 0 and 1.
*/
setHSL(h: number, s: number, l: number, colorSpace?: string): Color;
setHSL(h: number, s: number, l: number, colorSpace?: string): this;

/**
* Sets this color from a CSS context style string.
* @param contextStyle Color in CSS context style format.
*/
setStyle(style: string, colorSpace?: string): Color;
setStyle(style: string, colorSpace?: string): this;

/**
* Sets this color from a color name.
* Faster than {@link Color#setStyle .setStyle()} method if you don't need the other CSS-style formats.
* @param style Color name in X11 format.
*/
setColorName(style: string, colorSpace?: string): Color;
setColorName(style: string, colorSpace?: string): this;

/**
* Clones this color.
Expand All @@ -279,23 +279,23 @@ export class Color {
* Copies given color making conversion from `SRGBColorSpace` to `LinearSRGBColorSpace`.
* @param color Color to copy.
*/
copySRGBToLinear(color: Color): Color;
copySRGBToLinear(color: Color): this;

/**
* Copies given color making conversion from `LinearSRGBColorSpace` to `SRGBColorSpace`.
* @param color Color to copy.
*/
copyLinearToSRGB(color: Color): Color;
copyLinearToSRGB(color: Color): this;

/**
* Converts this color from `SRGBColorSpace` to `LinearSRGBColorSpace`.
*/
convertSRGBToLinear(): Color;
convertSRGBToLinear(): this;

/**
* Converts this color from `LinearSRGBColorSpace` to `SRGBColorSpace`.
*/
convertLinearToSRGB(): Color;
convertLinearToSRGB(): this;

/**
* Returns the hexadecimal value of this color.
Expand Down
Loading