Vector3: Fix set z optionality and reflect parameter name#2141
Merged
Methuselah96 merged 2 commits intothree-types:masterfrom May 9, 2026
Merged
Vector3: Fix set z optionality and reflect parameter name#2141Methuselah96 merged 2 commits intothree-types:masterfrom
Methuselah96 merged 2 commits intothree-types:masterfrom
Conversation
Methuselah96
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix declarations for
Vector3.set()andVector3.reflect().Evidence
JS implementation:
three.js/src/math/Vector3.js:84(set)three.js/src/math/Vector3.js:922(reflect)Declaration:
types/three/src/math/Vector3.d.ts:53(set)types/three/src/math/Vector3.d.ts:219(reflect)Observed mismatch:
set():zhas a default fallback in JS but is declared as required in the type declaration.reflect(): Parameter name does not match the JS implementation and JSDoc.Local Check
Scope
Vector3.d.ts