Skip to content

fix: correct InterleavedBuffer.set offset parameter optionality#2139

Merged
Methuselah96 merged 1 commit into
three-types:masterfrom
eunjiyun:fix-interleavedbuffer-set-offset
May 9, 2026
Merged

fix: correct InterleavedBuffer.set offset parameter optionality#2139
Methuselah96 merged 1 commit into
three-types:masterfrom
eunjiyun:fix-interleavedbuffer-set-offset

Conversation

@eunjiyun
Copy link
Copy Markdown
Contributor

@eunjiyun eunjiyun commented May 7, 2026

Summary

  • Aligns InterleavedBuffer.set() offset parameter with the JavaScript implementation.
  • Keeps the change limited to the declaration file.

Evidence

  • JS implementation: three.js/src/core/InterleavedBuffer.js:191
  • Declaration: types/three/src/core/InterleavedBuffer.d.ts:107
  • Mismatch: offset has a default value of 0 in JS but is declared as required in the type declaration.

Check

  • Checked the declaration diff manually.
  • pnpm test failed: unrelated ESLint plugin error.

@Methuselah96 Methuselah96 merged commit b6570f2 into three-types:master May 9, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants