Skip to content

AtomicFunctionNode: Fix return types #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Methuselah96 merged 6 commits into from
May 2, 2026
Merged

AtomicFunctionNode: Fix return types #2128

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
df82852
AtomicFunctionNode: Return correct typed node
thelazylamaGit Apr 23, 2026
c94faa0
AtomicFunctionNode: Style improvement
thelazylamaGit Apr 23, 2026
4c541eb
AtomicFunctionNode: Formatting
thelazylamaGit Apr 23, 2026
0786c4e
AtomicFunctionNode: Use interface
thelazylamaGit Apr 23, 2026
3672625
Cleanup
Methuselah96 May 2, 2026
c771008
Cleanup
Methuselah96 May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 53 additions & 45 deletions types/three/src/nodes/gpgpu/AtomicFunctionNode.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,73 +11,81 @@ export type AtomicMethod =
| typeof AtomicFunctionNode.ATOMIC_OR
| typeof AtomicFunctionNode.ATOMIC_XOR;

declare class AtomicFunctionNode extends Node {
interface AtomicFunctionNodeInterface {
method: AtomicMethod;
pointerNode: Node;
valueNode: Node;
valueNode: Node | null;
parents: boolean;

constructor(method: AtomicMethod, pointerNode: Node, valueNode: Node);

static ATOMIC_LOAD: "atomicLoad";
static ATOMIC_STORE: "atomicStore";
static ATOMIC_ADD: "atomicAdd";
static ATOMIC_SUB: "atomicSub";
static ATOMIC_MAX: "atomicMax";
static ATOMIC_MIN: "atomicMin";
static ATOMIC_AND: "atomicAnd";
static ATOMIC_OR: "atomicOr";
static ATOMIC_XOR: "atomicXor";
}

declare const AtomicFunctionNode: {
new<TNodeType>(
method: AtomicMethod,
pointerNode: Node,
valueNode: Node | null,
): AtomicFunctionNode<TNodeType>;

ATOMIC_LOAD: "atomicLoad";
ATOMIC_STORE: "atomicStore";
ATOMIC_ADD: "atomicAdd";
ATOMIC_SUB: "atomicSub";
ATOMIC_MAX: "atomicMax";
ATOMIC_MIN: "atomicMin";
ATOMIC_AND: "atomicAnd";
ATOMIC_OR: "atomicOr";
ATOMIC_XOR: "atomicXor";
};

export type AtomicFunctionNode<TNodeType> = Node<TNodeType> & AtomicFunctionNodeInterface;

export default AtomicFunctionNode;

export const atomicFunc: (
export const atomicFunc: <TNodeType>(
method: AtomicMethod,
pointerNode: Node,
valueNode: Node,
) => AtomicFunctionNode;
pointerNode: Node<TNodeType>,
valueNode: Node | null,
) => AtomicFunctionNode<TNodeType>;

export const atomicLoad: (
pointerNode: Node,
) => AtomicFunctionNode;
export const atomicLoad: <TNodeType>(
pointerNode: Node<TNodeType>,
) => AtomicFunctionNode<TNodeType>;

export const atomicStore: (
pointerNode: Node,
export const atomicStore: <TNodeType>(
pointerNode: Node<TNodeType>,
valueNode: Node | number,
) => AtomicFunctionNode;
) => AtomicFunctionNode<TNodeType>;

export const atomicAdd: (
pointerNode: Node,
export const atomicAdd: <TNodeType>(
pointerNode: Node<TNodeType>,
valueNode: Node | number,
) => AtomicFunctionNode;
) => AtomicFunctionNode<TNodeType>;

export const atomicSub: (
pointerNode: Node,
export const atomicSub: <TNodeType>(
pointerNode: Node<TNodeType>,
valueNode: Node | number,
) => AtomicFunctionNode;
) => AtomicFunctionNode<TNodeType>;

export const atomicMax: (
pointerNode: Node,
export const atomicMax: <TNodeType>(
pointerNode: Node<TNodeType>,
valueNode: Node,
) => AtomicFunctionNode;
) => AtomicFunctionNode<TNodeType>;

export const atomicMin: (
pointerNode: Node,
export const atomicMin: <TNodeType>(
pointerNode: Node<TNodeType>,
valueNode: Node,
) => AtomicFunctionNode;
) => AtomicFunctionNode<TNodeType>;

export const atomicAnd: (
pointerNode: Node,
export const atomicAnd: <TNodeType>(
pointerNode: Node<TNodeType>,
valueNode: Node,
) => AtomicFunctionNode;
) => AtomicFunctionNode<TNodeType>;

export const atomicOr: (
pointerNode: Node,
export const atomicOr: <TNodeType>(
pointerNode: Node<TNodeType>,
valueNode: Node,
) => AtomicFunctionNode;
) => AtomicFunctionNode<TNodeType>;

export const atomicXor: (
pointerNode: Node,
export const atomicXor: <TNodeType>(
pointerNode: Node<TNodeType>,
valueNode: Node,
) => AtomicFunctionNode;
) => AtomicFunctionNode<TNodeType>;
Loading