Skip to content

SCAL-320072:Focused homepage should also enable updatedSpotterChatPrompt#562

Open
jishnupavithran007 wants to merge 1 commit into
mainfrom
SCAL-320072
Open

SCAL-320072:Focused homepage should also enable updatedSpotterChatPrompt#562
jishnupavithran007 wants to merge 1 commit into
mainfrom
SCAL-320072

Conversation

@jishnupavithran007

@jishnupavithran007 jishnupavithran007 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Before:
Screenshot 2026-06-25 at 9 30 01 AM

Screenshot 2026-06-25 at 9 30 28 AM

After:
Screenshot 2026-06-25 at 8 55 12 AM

@jishnupavithran007 jishnupavithran007 requested a review from a team as a code owner June 25, 2026 01:47

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request automatically enables the updated Spotter chat prompt (updatedSpotterChatPrompt=true) when the focused homepage experience (HomePage.Focused) is active, unless the developer has explicitly configured updatedSpotterChatPrompt. It also updates existing tests and adds a new test case to verify that an explicit false value for updatedSpotterChatPrompt is respected. I have no additional feedback to provide as the changes are well-implemented and covered by tests.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@pkg-pr-new

pkg-pr-new Bot commented Jun 25, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@562

commit: 63743f8

@jishnupavithran007 jishnupavithran007 changed the title SCAL-320072:focused homepage should also enable updatedSpotterChatPrompt SCAL-320072:Focused homepage should also enable updatedSpotterChatPrompt Jun 25, 2026

@shivam-kumar-ts shivam-kumar-ts left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants