Skip to content

SCAL-320129 removed default home page setting#559

Open
msk052002 wants to merge 3 commits into
mainfrom
SCAL-320129
Open

SCAL-320129 removed default home page setting#559
msk052002 wants to merge 3 commits into
mainfrom
SCAL-320129

Conversation

@msk052002

Copy link
Copy Markdown
Collaborator

No description provided.

@msk052002 msk052002 requested a review from a team as a code owner June 24, 2026 12:21

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the default values for navigationVersion and homepageVersion in AppEmbed, allowing the server's GA defaults to take over instead of forcing v2 by default. Corresponding unit tests in app.spec.ts have been updated to reflect this change. The review feedback suggests minor grammatical improvements to a test description and a code comment in app.spec.ts to ensure complete and clear sentences.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/embed/app.spec.ts Outdated
Comment thread src/embed/app.spec.ts Outdated
@pkg-pr-new

pkg-pr-new Bot commented Jun 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@559

commit: 76a78b5

msk052002 and others added 2 commits June 24, 2026 18:09
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant