Skip to content

SCAL-320065: remediate Dependabot security alerts in dev dependencies#558

Merged
yinstardev merged 1 commit into
mainfrom
chore/audit-fix-safe
Jun 24, 2026
Merged

SCAL-320065: remediate Dependabot security alerts in dev dependencies#558
yinstardev merged 1 commit into
mainfrom
chore/audit-fix-safe

Conversation

@yinstardev

Copy link
Copy Markdown
Contributor
  • bump yaml to ^2.9.0 (GHSA-48c2-rrv3-qjmp; only runtime dep flagged)
  • bump vite to ^6.4.3 (dev-server file-read / fs.deny / launch-editor)
  • remove unused pnpm-lock.yaml: CI builds with npm only, so it was a stale orphan generating duplicate alerts against a lockfile nothing installs from
  • gitignore pnpm-lock.yaml / yarn.lock so npm stays the single committed lockfile while contributors can still use any package manager locally

All in-range, non-breaking bumps; jest toolchain left untouched. Verified: 1132 tests passing and rollup build green.

@yinstardev yinstardev requested a review from a team as a code owner June 24, 2026 05:52

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .gitignore file to exclude non-npm lockfiles (pnpm-lock.yaml and yarn.lock), ensuring the project standardizes on npm. It also upgrades the yaml dependency to ^2.9.0 and the vite devDependency to ^6.4.3 in package.json. There are no review comments to address, and I have no further feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@pkg-pr-new

pkg-pr-new Bot commented Jun 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@558

commit: 0ec4d1a

@yinstardev yinstardev force-pushed the chore/audit-fix-safe branch from 0af33af to ff64e35 Compare June 24, 2026 06:02
Dependency security bumps (runtime, customer-facing):
- bump ts-deepmerge to ^8.0.0 (CVE-2026-12644). v8 switched to a named
  export, so update the import in utils.ts; merge() signature unchanged
- bump yaml to ^2.9.0 (GHSA-48c2-rrv3-qjmp)
- add a test covering the runtime YAML.parse path in AnswerService.getTML
  to guard against yaml-version regressions

Dev-tooling security bumps:
- bump vite to ^6.4.3 (dev-server file-read / fs.deny / launch-editor)

Remove dead Gatsby docs tooling. The docs site lives in the separate
developer-docs repo (its own Gatsby), which consumes only the SDK's
generated static/typedoc/typedoc.json. The SDK's Gatsby remnants were
unused legacy and the sole source of several transitive alerts:
- drop babel-preset-gatsby devDep (clears transitive yaml@1.x and tmp)
- drop orphaned command-line-args (only fed the deleted script)
- delete scripts/gatsby-commands.js and jest-puppeteer.config.js
  (referenced by nothing; gatsby/puppeteer not installed)
- remove broken build-and-publish script (called non-existent
  build:gatsby / publish scripts)

Lockfile hygiene:
- remove unused pnpm-lock.yaml; CI builds with npm only
- gitignore pnpm-lock.yaml / yarn.lock to keep npm the single lockfile

All in-range, non-breaking bumps; jest toolchain untouched.
Verified: 1133 tests passing, rollup build green, and docgen still
emits static/typedoc/typedoc.json (the developer-docs contract).
@yinstardev yinstardev force-pushed the chore/audit-fix-safe branch from ff64e35 to 0ec4d1a Compare June 24, 2026 06:54
@yinstardev yinstardev merged commit b84fd05 into main Jun 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants