Skip to content

SCAL-319872: Add SpotterAnalyst action overrides for 26.8.0.cl#556

Open
bahetirisabh wants to merge 5 commits into
thoughtspot:mainfrom
bahetirisabh:SCAL-319872
Open

SCAL-319872: Add SpotterAnalyst action overrides for 26.8.0.cl#556
bahetirisabh wants to merge 5 commits into
thoughtspot:mainfrom
bahetirisabh:SCAL-319872

Conversation

@bahetirisabh

Copy link
Copy Markdown

Summary

  • Add 6 new Action enum entries (SpotterAnalystShare, SpotterAnalystEdit, SpotterAnalystCreate, SpotterAnalystDelete, SpotterAnalystMakeACopy, SpotterAnalystSidebar) to types.ts for the 26.8.0.cl release
  • Add spotterAnalystLabel field to SpotterSidebarViewConfig in conversation.ts
  • Add hiddenActions, disabledActions, and APP_INIT tests for the new actions/config in conversation.spec.ts

Test plan

  • All 49 tests in conversation.spec.ts pass
  • hiddenActions verified for all 6 SpotterAnalyst* actions
  • disabledActions verified for all 6 SpotterAnalyst* actions
  • spotterAnalystLabel forwarded correctly in embedParams.spotterSidebarConfig via APP_INIT

🤖 Generated with Claude Code

- Add 6 new Action enum entries (SpotterAnalystShare, Edit, Create, Delete, MakeACopy, Sidebar) to types.ts
- Add spotterAnalystLabel to SpotterSidebarViewConfig in conversation.ts
- Add hiddenActions, disabledActions, and APP_INIT tests in conversation.spec.ts

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@bahetirisabh bahetirisabh requested a review from a team as a code owner June 22, 2026 17:39

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several new Spotter Analyst actions to the Action enum, updates the corresponding embed tests, and introduces a new spotterAnalystLabel configuration option to the SpotterSidebarViewConfig. The review feedback correctly identifies that the JSDoc comments for the new enum members and the configuration option violate the repository's style guide regarding canonical tag ordering, specifically noting that @Version should be ordered before @default and @example tags.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/embed/conversation.ts
Comment thread src/types.ts
- Fix @version/@example order in Action enum to match established pattern
- Replace @default tag with inline prose in SpotterSidebarViewConfig
  to match other string label fields in the interface

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Comment thread src/types.ts
Comment thread src/types.ts
bahetirisabh and others added 2 commits June 24, 2026 12:14
- Restore garbled bullet-point list in Action enum comment (types.ts)
- Fix @version/@default tag ordering for spotterAnalystLabel and
  spotterAnalystsLabel per review feedback (conversation.ts)

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
… format

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants