SCAL-319872: Add SpotterAnalyst action overrides for 26.8.0.cl#556
SCAL-319872: Add SpotterAnalyst action overrides for 26.8.0.cl#556bahetirisabh wants to merge 5 commits into
Conversation
- Add 6 new Action enum entries (SpotterAnalystShare, Edit, Create, Delete, MakeACopy, Sidebar) to types.ts - Add spotterAnalystLabel to SpotterSidebarViewConfig in conversation.ts - Add hiddenActions, disabledActions, and APP_INIT tests in conversation.spec.ts Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request adds several new Spotter Analyst actions to the Action enum, updates the corresponding embed tests, and introduces a new spotterAnalystLabel configuration option to the SpotterSidebarViewConfig. The review feedback correctly identifies that the JSDoc comments for the new enum members and the configuration option violate the repository's style guide regarding canonical tag ordering, specifically noting that @Version should be ordered before @default and @example tags.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
- Restore garbled bullet-point list in Action enum comment (types.ts) - Fix @version/@default tag ordering for spotterAnalystLabel and spotterAnalystsLabel per review feedback (conversation.ts) Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
… format Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Summary
Actionenum entries (SpotterAnalystShare,SpotterAnalystEdit,SpotterAnalystCreate,SpotterAnalystDelete,SpotterAnalystMakeACopy,SpotterAnalystSidebar) totypes.tsfor the 26.8.0.cl releasespotterAnalystLabelfield toSpotterSidebarViewConfiginconversation.tshiddenActions,disabledActions, andAPP_INITtests for the new actions/config inconversation.spec.tsTest plan
conversation.spec.tspasshiddenActionsverified for all 6SpotterAnalyst*actionsdisabledActionsverified for all 6SpotterAnalyst*actionsspotterAnalystLabelforwarded correctly inembedParams.spotterSidebarConfigvia APP_INIT🤖 Generated with Claude Code