Skip to content

SCAL-310667 Add loaderHeadline and loaderTips to SpotterVizConfig#544

Merged
g-nitin-t merged 1 commit into
mainfrom
SCAL-310667
Jun 23, 2026
Merged

SCAL-310667 Add loaderHeadline and loaderTips to SpotterVizConfig#544
g-nitin-t merged 1 commit into
mainfrom
SCAL-310667

Conversation

@g-nitin-t

Copy link
Copy Markdown
Collaborator

No description provided.

@g-nitin-t g-nitin-t requested a review from a team as a code owner May 28, 2026 13:20

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two new configuration options, loaderHeadline and loaderTips, to the SpotterVizConfig interface in src/embed/spotter-viz-utils.ts to allow customization of the loading state headline and tips in SpotterViz. The JSDoc examples in src/embed/app.ts, src/embed/liveboard.ts, and src/embed/spotter-viz-utils.ts have been updated to demonstrate their usage. There are no review comments, and the changes conform to the repository's style guidelines, so I have no feedback to provide.

@pkg-pr-new

pkg-pr-new Bot commented May 28, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@544

commit: 9bbd58c

@g-nitin-t g-nitin-t force-pushed the SCAL-310667 branch 2 times, most recently from 6593715 to 7ff5551 Compare June 2, 2026 06:53
@g-nitin-t g-nitin-t force-pushed the SCAL-310667 branch 2 times, most recently from a34f885 to 30cff32 Compare June 10, 2026 08:59
@g-nitin-t g-nitin-t merged commit 33e9921 into main Jun 23, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants