SCAL-312776: deprecate V1/v2 homepage and nav and keep V3 as default#530
SCAL-312776: deprecate V1/v2 homepage and nav and keep V3 as default#530jishnupavithran007 wants to merge 7 commits into
Conversation
commit: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the AppEmbed configuration and related types to reflect the deprecation of V1 and V2 home page experiences, establishing V3 (ModularWithStylingChanges) as the new baseline. Key changes include updating JSDoc documentation to flag deprecated properties, removing the explicit modularHomeExperience parameter from URL generation (favoring homepageVersion), and updating unit tests to match these URL parameter changes. Feedback was provided regarding the placement of {@link} tags within @deprecated JSDoc blocks to ensure proper rendering and adherence to the repository's style guide.
jishnupavithran007
changed the title
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces new CSS variables for styling the left navigation panel, deprecates the V1 and V2 home page and navigation experiences, and updates the default navigation and home page versions to V3. It also removes the deprecated modularHomeExperience default parameter. The review feedback points out that numerous unit tests in app.spec.ts will fail because their expected URLs do not account for the new default parameters (navigationVersion=v3 and homepageVersion=v3). Additionally, the reviewer provides actionable suggestions to fix JSDoc tag ordering, correct typos, and standardize the casing of version names (e.g., using uppercase 'V3' instead of 'v3') across comments and documentation to ensure consistency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
2 participants
No description provided.