[Snyk] Fix for 2 vulnerabilities#215
Open
mnk-blr wants to merge 1 commit into
Open
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-MINIMATCH-15353389 - https://snyk.io/vuln/SNYK-JS-TOOTALLNATEONCE-15250612
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| "@typescript-eslint/parser": "^5.59.5", | ||
| "dts-bundle": "^0.7.3", | ||
| "eslint": "^8.56.0", | ||
| "eslint": "^9.1.0", |
Contributor
There was a problem hiding this comment.
🚨 Breaking Change - ESLint v9 Incompatibility
ESLint v9 requires @typescript-eslint v7+ but this package still uses v5.59.5. This will cause build failures.
Required changes:
- Update
@typescript-eslint/parserto^7.0.0 - Update
@typescript-eslint/eslint-pluginto^7.0.0 - Consider migrating
.eslintrc.jsto flat config format as ESLint v9 prefers it
Impact: ESLint will fail to run with current configuration.
| "eslint-plugin-testing-library": "^5.11.0", | ||
| "jest": "^27.4.6", | ||
| "jsdom": "^19.0.0", | ||
| "jest": "^29.0.0", |
Contributor
There was a problem hiding this comment.
🚨 Breaking Change - Jest v29 Requires ts-jest v29+
Jest v29 is incompatible with ts-jest v27.1.1. This will cause test failures.
Required changes:
- Update
ts-jestto^29.0.0 - Update
@types/jestto^29.0.0 - Migrate Jest configuration to remove deprecated
globalssyntax
Files to update:
jest.config.sdk.js- Replaceglobals.ts-jestwithtransformconfiguration- Test files using
@testing-library/react-hooksneed migration to RTL 13+ patterns
| "jest": "^27.4.6", | ||
| "jsdom": "^19.0.0", | ||
| "jest": "^29.0.0", | ||
| "jsdom": "^23.0.0", |
Contributor
There was a problem hiding this comment.
JSDOM v23 introduces breaking changes in Node.js globals handling that could affect tests using postMessage patterns (critical for this SDK's iframe communication).
Recommended actions:
- Test the postMessage bridge functionality thoroughly
- Verify
src/main/post-message-event-bridge.spec.tsstill passes - Check if any polyfills are needed for updated JSDOM behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix 2 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
package.jsonpackage-lock.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-MINIMATCH-15353389
SNYK-JS-TOOTALLNATEONCE-15250612
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.