[Snyk] Security upgrade eslint from 8.42.0 to 9.1.0#214
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-MINIMATCH-15353389 - https://snyk.io/vuln/SNYK-JS-AJV-15274295
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 58553f7 |
| "@vitejs/plugin-react": "^4.0.0", | ||
| "autoprefixer": "^10.4.14", | ||
| "eslint": "^8.38.0", | ||
| "eslint": "^9.1.0", |
There was a problem hiding this comment.
🚨 Critical: ESLint v9 upgrade requires additional changes to work properly:
-
Configuration incompatibility: The existing
.eslintrc.cjsuses legacy format that's incompatible with ESLint v9. ESLint v9 requires the new flat config format (eslint.config.js). -
Plugin version conflicts: The TypeScript ESLint plugins (
@typescript-eslint/eslint-plugin: ^5.59.0and@typescript-eslint/parser: ^5.59.0) are not compatible with ESLint v9. They need to be updated to v6.x or v7.x. -
Monorepo version conflict: The main project still uses ESLint v8.56.0, creating inconsistent linting behavior across the codebase.
-
Missing lock file update: The warning about pnpm-lock.yaml failing to update will cause dependency resolution issues.
| "eslint": "^9.1.0", | |
| "eslint": "^8.42.0", |
Recommendation: Hold this PR until the ESLint configuration is migrated to flat config format and plugin versions are updated.
❌ PR Review Summary - NOT MERGEABLEThis Snyk security upgrade PR attempts to fix 2 high-severity vulnerabilities by updating ESLint from v8.42.0 to v9.1.0. However, several critical issues prevent this PR from being safely merged: 🚨 Critical Issues
|
Snyk has created this PR to fix 2 vulnerabilities in the pnpm dependencies of this project.
Snyk changed the following file(s):
playground/app/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-MINIMATCH-15353389
SNYK-JS-AJV-15274295
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)