[Snyk] Security upgrade @thoughtspot/ts-chart-sdk from 0.0.2-alpha.16 to 1.0.0#211
[Snyk] Security upgrade @thoughtspot/ts-chart-sdk from 0.0.2-alpha.16 to 1.0.0#211mnk-blr wants to merge 1 commit into
Conversation
…reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ROLLUP-15340920
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against c5c12ba |
| }, | ||
| "dependencies": { | ||
| "@thoughtspot/ts-chart-sdk": "0.0.2-alpha.16", | ||
| "@thoughtspot/ts-chart-sdk": "1.0.0", |
There was a problem hiding this comment.
🚨 Critical Version Inconsistency
This change upgrades to SDK version 1.0.0, but this creates a significant version inconsistency:
- Other examples use
@thoughtspot/ts-chart-sdk: 2.7.6 - Main SDK is at version
2.9.2 - This gauge example would be running a major version behind
Recommendation: Use the same version as other examples (2.7.6) or latest (2.9.2) to ensure API compatibility and consistency across examples.
Potential Impact: Users following the gauge example might encounter deprecated APIs or missing features available in newer versions.
| }, | ||
| "dependencies": { | ||
| "@thoughtspot/ts-chart-sdk": "0.0.2-alpha.16", | ||
| "@thoughtspot/ts-chart-sdk": "1.0.0", |
There was a problem hiding this comment.
📋 Semver Format Change
Note: This change also switches from an exact version (0.0.2-alpha.16) to a caret range (^1.0.0).
While caret ranges are generally good practice for automatic minor/patch updates, ensure this aligns with your dependency management strategy across all examples.
🔍 Code Review SummaryStatus: ❌ Not Recommended for Merge Critical Issues Found🚨 Major Version Inconsistency
Recommendations
Security NoteWhile this PR addresses Snyk security vulnerabilities, the version downgrade may reintroduce other security issues present in older SDK versions. Verdict: Please address the version inconsistency before merging to maintain example consistency and avoid potential API compatibility issues. |
Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
example/gauge/package.jsonexample/gauge/package-lock.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-ROLLUP-15340920
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal