[Snyk] Fix for 2 vulnerabilities#209
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-MINIMATCH-15309438 - https://snyk.io/vuln/SNYK-JS-AJV-15274295
⛔ Snyk checks have failed. 19 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| "@typescript-eslint/parser": "^5.59.5", | ||
| "dts-bundle": "^0.7.3", | ||
| "eslint": "^8.56.0", | ||
| "eslint": "^9.1.0", |
There was a problem hiding this comment.
🚨 Breaking Change - ESLint v9 Migration Required
This upgrade from ESLint v8 to v9 introduces breaking changes that require configuration updates:
- Flat Config Migration: ESLint v9 uses flat config as default. The current
.eslintrc.*files need migration toeslint.config.js - Removed Rules: Several rules have been removed or deprecated
- Plugin Compatibility: Some ESLint plugins may not be compatible with v9
Required Actions:
- Migrate from
.eslintrc.jstoeslint.config.jsflat config format - Update or replace incompatible plugins
- Test all lint rules still work as expected
- Update CI/build scripts if they depend on specific ESLint behavior
Risk: This change will likely break the current lint configuration and CI pipeline.
| "eslint-config-airbnb-base": "15.0.0", | ||
| "eslint-config-prettier": "^6.9.0", | ||
| "eslint-import-resolver-typescript": "^2.0.0", | ||
| "eslint-import-resolver-typescript": "^3.0.0", |
There was a problem hiding this comment.
eslint-import-resolver-typescript v2→v3 may have breaking changes. Verify import resolution still works correctly with the existing TypeScript configuration.
| "eslint-plugin-simple-import-sort": "^10.0.0", | ||
| "eslint-plugin-testing-library": "^5.11.0", | ||
| "jest": "^27.4.6", | ||
| "jest": "^29.0.0", |
There was a problem hiding this comment.
🚨 Breaking Change - Jest v29 Migration Required
Jest v27→v29 includes significant breaking changes that require migration:
Key Breaking Changes:
- Default test environment changed from
nodetojsdom jest.resetModules()behavior changes- Some APIs removed (e.g.,
jest.setTimeout()moved tojest.setSystemTime()) testURLoption removed
Required Actions:
- Update Jest configuration to specify test environment explicitly
- Review and update any tests using deprecated APIs
- Test all existing test suites still pass
- Update any Jest-related scripts or CI configuration
Risk: Tests may fail after this upgrade without proper migration.
PR Review SummaryWhile this Snyk security fix addresses critical ReDoS vulnerabilities (minimatch & ajv), it introduces breaking changes that require additional work before merging. Critical Issues Found:🚨 ESLint v8→v9 Breaking Changes
🚨 Jest v27→v29 Breaking Changes
Recommended Actions Before Merge:
Security Value:✅ Fixes high-severity ReDoS vulnerabilities (scores 170 & 156) Recommendation: Address breaking changes before merging, or consider a smaller targeted security fix for the immediate vulnerabilities. |
Snyk has created this PR to fix 2 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
package.jsonpackage-lock.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-MINIMATCH-15309438
SNYK-JS-AJV-15274295
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)