Skip to content

[Snyk] Fix for 2 vulnerabilities#209

Open
mnk-blr wants to merge 1 commit into
mainfrom
snyk-fix-e591b20b83a4dc33a05221f3d0f289f8
Open

[Snyk] Fix for 2 vulnerabilities#209
mnk-blr wants to merge 1 commit into
mainfrom
snyk-fix-e591b20b83a4dc33a05221f3d0f289f8

Conversation

@mnk-blr

@mnk-blr mnk-blr commented Feb 24, 2026

Copy link
Copy Markdown

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • package.json
  • package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-MINIMATCH-15309438
  170  
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  156  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

@mnk-blr

mnk-blr commented Feb 24, 2026

Copy link
Copy Markdown
Author

Snyk checks have failed. 19 issues have been found so far.

Status Scanner Critical High Medium Low Total (19)
Open Source Security 2 17 0 0 19 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Comment thread package.json
"@typescript-eslint/parser": "^5.59.5",
"dts-bundle": "^0.7.3",
"eslint": "^8.56.0",
"eslint": "^9.1.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Breaking Change - ESLint v9 Migration Required

This upgrade from ESLint v8 to v9 introduces breaking changes that require configuration updates:

  1. Flat Config Migration: ESLint v9 uses flat config as default. The current .eslintrc.* files need migration to eslint.config.js
  2. Removed Rules: Several rules have been removed or deprecated
  3. Plugin Compatibility: Some ESLint plugins may not be compatible with v9

Required Actions:

  • Migrate from .eslintrc.js to eslint.config.js flat config format
  • Update or replace incompatible plugins
  • Test all lint rules still work as expected
  • Update CI/build scripts if they depend on specific ESLint behavior

Risk: This change will likely break the current lint configuration and CI pipeline.

Comment thread package.json
"eslint-config-airbnb-base": "15.0.0",
"eslint-config-prettier": "^6.9.0",
"eslint-import-resolver-typescript": "^2.0.0",
"eslint-import-resolver-typescript": "^3.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Major Version Update

eslint-import-resolver-typescript v2→v3 may have breaking changes. Verify import resolution still works correctly with the existing TypeScript configuration.

Comment thread package.json
"eslint-plugin-simple-import-sort": "^10.0.0",
"eslint-plugin-testing-library": "^5.11.0",
"jest": "^27.4.6",
"jest": "^29.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Breaking Change - Jest v29 Migration Required

Jest v27→v29 includes significant breaking changes that require migration:

Key Breaking Changes:

  • Default test environment changed from node to jsdom
  • jest.resetModules() behavior changes
  • Some APIs removed (e.g., jest.setTimeout() moved to jest.setSystemTime())
  • testURL option removed

Required Actions:

  • Update Jest configuration to specify test environment explicitly
  • Review and update any tests using deprecated APIs
  • Test all existing test suites still pass
  • Update any Jest-related scripts or CI configuration

Risk: Tests may fail after this upgrade without proper migration.

@claude

claude Bot commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

PR Review Summary

⚠️ NOT READY FOR MERGE

While this Snyk security fix addresses critical ReDoS vulnerabilities (minimatch & ajv), it introduces breaking changes that require additional work before merging.

Critical Issues Found:

🚨 ESLint v8→v9 Breaking Changes

  • Requires migration from .eslintrc.* to flat config (eslint.config.js)
  • Multiple plugins may be incompatible with v9
  • Will break current lint pipeline

🚨 Jest v27→v29 Breaking Changes

  • Default test environment changes
  • API deprecations and removals
  • May break existing test suites

⚠️ Additional Updates Needed

  • eslint-import-resolver-typescript v2→v3 (potential breaking changes)
  • Various transitive dependency updates with potential compatibility issues

Recommended Actions Before Merge:

  1. ESLint Migration: Update configuration to flat config format
  2. Jest Migration: Review/update test configurations and deprecated API usage
  3. Testing: Run full test suite to verify compatibility
  4. CI Verification: Ensure build pipeline works with new dependency versions
  5. Plugin Compatibility: Verify all ESLint plugins work with v9

Security Value:

✅ Fixes high-severity ReDoS vulnerabilities (scores 170 & 156)

Recommendation: Address breaking changes before merging, or consider a smaller targeted security fix for the immediate vulnerabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants