[Snyk] Security upgrade eslint from 8.57.1 to 10.0.0#203
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-AJV-15274295
⛔ Snyk checks have failed. 18 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| "@typescript-eslint/parser": "^5.59.5", | ||
| "dts-bundle": "^0.7.3", | ||
| "eslint": "^8.56.0", | ||
| "eslint": "^10.0.0", |
There was a problem hiding this comment.
Critical compatibility issue: ESLint 10.0.0 requires @typescript-eslint v8.x or later, but this project uses v5.59.5. This combination will cause runtime errors and break the linting pipeline.
You'll need to also upgrade:
@typescript-eslint/eslint-pluginfrom ^5.59.5 to ^8.0.0@typescript-eslint/parserfrom ^5.59.5 to ^8.0.0
This is a breaking change that requires testing of the entire ESLint configuration.
| "@typescript-eslint/parser": "^5.59.5", | ||
| "dts-bundle": "^0.7.3", | ||
| "eslint": "^8.56.0", | ||
| "eslint": "^10.0.0", |
There was a problem hiding this comment.
Lock file inconsistency: The PR mentions "Failed to update pnpm-lock.yaml" but this project uses package-lock.json (npm), not pnpm. After merging, you must run npm install to update the lock file, otherwise the dependency resolution will be incomplete.
Code Review SummaryStatus: This Snyk security upgrade to ESLint 10.0.0 addresses vulnerability SNYK-JS-AJV-15274295 (ReDoS with severity score 157), but introduces critical compatibility issues that will break the build. 🚨 Blocking Issues
🛠️ Required Actions Before Merge
✅ Positive Aspects
💡 RecommendationConsider upgrading this as a coordinated change that includes all necessary dependency updates, or investigate if the AJV vulnerability can be mitigated through other means that don't require breaking the ESLint setup. |
Snyk has created this PR to fix 1 vulnerabilities in the pnpm dependencies of this project.
Snyk changed the following file(s):
package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-AJV-15274295
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)