Conversation
Contributor
Author
|
I’d like to reopen this discussion. Do you have any thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
Administrate::ApplicationControllerby splitting its responsibilities into focused concerns.The default controller includes all concerns required for the existing HTML CRUD behavior, so this change preserves the current behavior while making customization more explicit.
With this structure, custom controllers can compose only the functionality they need. For example:
HtmlRendererindex, ornewandcreate.I understand the concern that concerns can hide methods that still belong to the controller. In this case, however, the goal is not only to organize methods, but to make each responsibility independently composable and replaceable. The included concerns are explicitly listed in
ApplicationController, and custom controllers can choose their own composition.Existing HTML CRUD behavior and customization points are preserved.
WIP