Add move_camera_to usage example - #798
Conversation
❌ Deploy Preview for splashkit failed.
|
Rhinoatron
left a comment
There was a problem hiding this comment.
Amazing work on this task. The larger game world is visually engaging, the world objects make the camera movement easy to see, and the player and camera movement appear to work well. However, I’d like to request a few changes before approval. The task requires implementations in C++, Python, C# OOP, and C# top-level, but both C# versions are currently missing. The required GIF also needs to be added to the public/usage-examples/camera/ folder. I can see the recording embedded in the PR description and is not included as one of the repository’s usage-example files. Once the two C# implementations and the GIF are added, I’ll be happy to take another look. 🙂
Thanks for taking the time to review my PR and for the helpful feedback. I have now addressed all of the requested changes: Added the C# OOP implementation. The changes have been committed and pushed to this PR. When you have a chance, I'd appreciate it if you could take another look. Thank you! |
Rhinoatron
left a comment
There was a problem hiding this comment.
Thank you for making the requested changes I’ve reviewed the latest commits and confirmed that the C# OOP and C# top level implementations have now been added, along with the required GIF in the correct usage example folder. All four versions demonstrate the same player movement and camera following behaviour within a larger game world, and the example meets the task requirements. Approved!
Osaid2993
left a comment
There was a problem hiding this comment.
Hi @jankiluitel, nice visual example. Could you simplify it so move_camera_to stays the main focus? Please also remove non-SplashKit functions like Math.Max, Math.Min, max, and min, and update the C# top-level colours to use functions like ColorWhite() and ColorBlack().
Once updated, I’ll review it again.
Thanks for the review and feedback! I've now simplified the example so that move_camera_to() is the main focus, removed the non-SplashKit helper functions (Math.Max, Math.Min, max, and min), updated the C# top-level implementation to use SplashKit colour functions, and replaced the GIF to match the updated example. The changes have been pushed, and I'd appreciate it if you could take another look. Thanks! |
himanshigaba22
left a comment
There was a problem hiding this comment.
Great work! The requested changes have been addressed, including the C# implementations, GIF, and simplification of the example to keep move_camera_to() as the main focus. The example is now clear, consistent across all languages, and demonstrates the target function well. Approved
Summary
This PR adds a new
move_camera_tousage example demonstrating how to create a camera that follows a player around a world larger than the screen.Files Added
move_camera_to-1-example.cppmove_camera_to-1-example.pymove_camera_to-1-example.txtTesting