Skip to content

Docs/ppi help privacy - #509

Open
David-Tenni wants to merge 1492 commits into
thoth-tech:developmentfrom
ontrack-features-t2-2026:docs/ppi-help-privacy
Open

Docs/ppi help privacy#509
David-Tenni wants to merge 1492 commits into
thoth-tech:developmentfrom
ontrack-features-t2-2026:docs/ppi-help-privacy

Conversation

@David-Tenni

Copy link
Copy Markdown

Description

Adds a help-text pack for the task-level Peer Progress Indicator (PPI) widget — a label, tooltip, and expanded explanation for each of the six widget states (normal, zero, suppressed, unavailable, stale, disabled). Explains the displayed value as an anonymous, group-level aggregate rather than an individual ranking, and avoids wording that could read as shaming or pressuring students. Confirmed via repo search that no unit-level PPI view exists yet, so this covers task-level only — noted in the doc itself.

Fixes PPI-D01

Type of change

  • This change requires a documentation update
    This is a documentation change so requires no testing

Checklist:

  • My code follows the style guidelines of this project

  • I have performed a self-review of my own code

  • I have made corresponding changes to the documentation

  • My changes generate no new warnings

b0ink added 30 commits June 3, 2026 16:43
* refactor: format codebase and implement lint checks

* ci: fail lint workflow on warnings

* chore: remove rule ignore

* refactor: remove empty lifecycle methods

* chore: revert empty method

* refactor: switch to modern lifecycle methods

* refactor: switch to records

* refactor: consistent type assertions

* refactor: consistent type definitions

* refactor: remove empty block statements

* chore: re-enable no useless escape rule

* chore: reenable no misleading character class rule

* chore: no wrapper object types

* chore: fix no constant binary expression

* refactor: remove this alias

* refactor: no unused expressions

* refactor: prefer const

* chore: no var rule

* refactor: no unused vars

* refactor: no inline templates

* refactor: no inline styles

* refactor: enforce modern angular control flow

* refactor: no empty functions

* chore: update pull request template

* refactor: consistent generic constructors

* refactor: no empty object types

* chore: remove todo

* refactor: remove use of any

* refactor: enforce alt text

* chore: enforce no empty content

* chore: add todo

* chore: add recommended rules

* refactor: sort tailwind classes
* chore: init communication system editor

* feat: add core communications logic

* refactor: improve ui layout

* refactor: preview email

* refactor: ability to edit conditions and actions

* refactor: clean up ui layout

* feat: enable set execution

* refactor: improve layout

* refactor: improve ui layout

* feat: add confirmation modals to execute rule and set

* feat: add scheduling ui

* chore: remove duplicate header

* fix: ensure students are loaded

* refactor: move buttons

* fix: disable horizontal scrolling

* refactor: improve ui

* chore: revert full width change

* chore: improve current week ui

* chore: format

* feat: add spec con days condition

* feat: add task comment action

* chore: fix layout

* chore: remove unnecessary shortcuts

* refactor: use server side current week number

* refactor: modularise components

* chore: fix styling
b0ink and others added 28 commits July 7, 2026 15:59
feat: add peer progress indicator (ppi) data contract, mock service, …
…ppi-widget-states

feat: add safe loading, hidden, unavailable and error states to task-sheet PPI widget (PPI-F03)
@Clupai8o0

Copy link
Copy Markdown

Both of these are aimed at a base that cannot review them, and it is worth fixing before either gets any older.

thoth-tech/doubtfire-web development was last touched on 2026-06-04 and is 1,481 commits behind 11.0.x with nothing unique on it. Our branches descend from the 11.0.x line, so the diff GitHub renders is the entire Angular 17 to 22 migration plus your work. That is why #509 shows 1,113 files for what is a 649 line documentation change, and #513 shows 1,123 files for a 345 line adapter. Nobody can review that, which is why both have sat with zero reviews since 18 August.

This is the exact shape that closed all fifteen of our upstream PRs in T1, and it closed one of ours in the org this trimester too (doubtfire-web#8, +68930/-43235 across 1108 files into development).

Retargeting at Feature/Peers-Progress does not fix it, which I checked before suggesting it. That branch is 603 commits behind 11.0.x and its merge base with both of your heads is chore(release): 10.0.1-22 from March. It is stranded on the 10.0.x line. So neither existing thoth-tech branch is a viable base.

What that leaves:

  1. A Feature/* branch on thoth-tech/doubtfire-web cut from current 11.0.x has to be asked for. The notifications stream hit the same wall, so this is one ask covering both.
  2. Promote from origin/feature/peer-progress-indicator rather than from an individual work branch. Both of these are opened from docs/ppi-help-privacy and feature/ppi-data-adapter directly, which means they carry other contributors' PPI work uncredited and omit what has merged since. In particular Feature/ppi data adapter #513 promotes a version of peer-progress-unit-summary-state.ts that the org corrected on 20 August, with a spec asserting the superseded behaviour.

Two smaller things while these are open.

The CI is not missing, it is waiting on someone. Both head branches have workflow runs sitting at action_required, which is thoth-tech's approval gate for a run from an outside contributor. Somebody there has to click. Until then the "21/21 passing, run twice" line in #513 has no independent evidence attached, which is a lot to ask of a reviewer looking at 1,123 files.

#513's body names getUnitSummary(). No such symbol exists on the branch. The method is getMockUnitSummary(), which is the better name and the one the "mock-only" caveat should point at.

Happy to help get the branch request in, it is the same conversation for notifications.

@Clupai8o0 Clupai8o0 mentioned this pull request Aug 22, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants