Skip to content

Dry run of a submodule update lists an excluded submodule as one to nest #230

Open

Description

@olfway

Thanks for merging #202!

I used 1.2.2 for the next tdesktop sync, and it worked: 11 upstream commits, three nested repos pulled, no conflicts.

I found one minor problem

Version: git-nested 1.2.2, git 2.56.1, macOS.

Setup: a fork of tdesktop, with submodules init --recursive. QuickJS is nested at Telegram/ThirdParty/widget-sandbox/packages/ios/Sources/CQuickJS/quickjs.

We do not want its test262 submodule, so its .gitnested has:

  submodules: nest
  exclude:
  - test262

Command: in the fork, origin is the tdesktop upstream. An update from tdesktop 346f10f to bf4f714. This moves quickjs to fbc91d85432b.

git nested submodules update --dry-run origin/dev

Actual:

would merge 11 commits of origin/dev
Telegram/ThirdParty/twidget: would pull to 866f0971e7cc
Telegram/ThirdParty/widget-sandbox: would pull to a6cf612b9bab
Telegram/ThirdParty/widget-sandbox/packages/ios/Sources/CQuickJS/quickjs: would pull to fbc91d85432b
Telegram/ThirdParty/widget-sandbox/packages/ios/Sources/CQuickJS/quickjs/test262: would nest at 5ef1e5723be9

Expected: no test262 line.

The real update follows exclude and does not nest test262.

Only the dry-run output is wrong.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions