Add Garmin connector - #1253
Open
AndyReifman wants to merge 4 commits into
Open
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Complexity | 4 medium |
🟢 Metrics 116 complexity · 4 duplication
Metric Results Complexity 116 Duplication 4
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Owner
|
Hi @AndyReifman . Thanks a lot for this ! Wanted to do it for years. I will take a look at it under the 2 next weeks ! Thanks ! I know it's huge ! |
|
I was in search for exactly this feature, since i had been experimenting with the garminconnect library within another side playground "project". I just run a test build/ package with your branch the sync is working really fine for me. Environment: MacOS 27.0 Beta (26A5388g)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the ability to sync activities from Garmin. Garmin doesn't expose a public API, but there is a python package called garminconnect, so I wrote a small python script that allows for authentication and syncing of activities.
I'm not super familiar with Typescript so I mostly duplicated what the Strava connector is doing with a few hacky bits here and there to make the Python code fit. I'm sure there are cleaner ways to accomplish what I've done.
A few caveats/notes
Morning/Afternoon <activity type>