Open
Conversation
thomasahle
requested changes
Nov 26, 2025
Owner
thomasahle
left a comment
thomasahle
left a comment
There was a problem hiding this comment.
Thank you for the PR.
Adding a polyglot.ini file is a good idea.
Please remove the .idea folder, and consider whether the other changes (uci.py and sunfish2.py) are necessary.
ShuyangDSun
force-pushed
the
XBoard_Protocol
branch
from
38b6b8b to
c738f40
Compare
Author
|
I didn't realize that I was making a PR for the original project repo. The change in uci.py was made because when using XBoard to test sunfish.py the translation from Xboard to UCI created an issue where 'times' only had 3 values and so the modification to those lines is just a quick fix to make sure there are 4 values to unpack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Polyglot.ini file to translate from UCI to XBoard protocol.
Edited tools.py to account for missing Xboard parameter.
Run
xboard -fcp "polyglot ./polyglot.ini"in terminal at root directory to test chess bot.