Repository navigation
Fix mass user lockout caused by IP-based axes lockout behind proxy - #41
Merged
Merged
Conversation
…based Co-authored-by: thom-techlete <176420111+thom-techlete@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate and fix user account lockout problem
Fix mass user lockout caused by IP-based axes lockout behind proxy
Mar 4, 2026
thom-techlete
marked this pull request as ready for review
March 4, 2026 22:12
thom-techlete
had a problem deploying
to
production
March 4, 2026 22:17 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All users were simultaneously locked out because
security.py(containing AXES config) was never imported intosettings.py, causing django-axes to fall back to defaults: IP-based lockout after 3 attempts. Behind a proxy, all users share one IP — any 3 failed attempts locked everyone out.Changes
settings.py— Explicit AXES configurationAXES_LOCKOUT_PARAMETERS = ["username"]: lockouts are now scoped to the targeted username, not the shared proxy IPAXES_FAILURE_LIMIT=5,AXES_COOLOFF_TIME=1,AXES_RESET_ON_SUCCESS=TrueAxesMiddlewareto correct position: afterSessionMiddleware, beforeAuthenticationMiddlewareusers/views.py— Login rate limiting@ratelimit(key="ip")→key="post:username"on the login view; rate lowered to6/mto align withAXES_FAILURE_LIMITsecurity_middleware.py—BasicRateLimitMiddlewareAXES_FAILURE_LIMITfrom settings instead of hardcoding5users/tests.pyAccountLockoutTestCasecovering: one user's failures don't lock others from the same IP, per-user counter independence, and lockout after limit is reachedOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.