refactor(storage): gaxios migration system test fix#8
Open
thiyaguk09 wants to merge 43 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Google Cloud Storage client to use the /storage/v1 prefix for API endpoints and ensures Content-Type: application/json headers are explicitly set for POST requests. It also includes significant updates to system tests, such as skipping problematic public access tests, improving error handling in cleanup routines, and ensuring Node 18 compatibility in the transport layer. Review feedback identified a potential TypeError in getServiceAccount due to missing optional chaining, a bug in a test timeout callback that would cause tests to hang, and a potential type mismatch in error status assertions within the system tests.
thiyaguk09
changed the title
thiyaguk09
changed the title
thiyaguk09
force-pushed
the
node18/system-test
branch
from
957daf5 to
70a0132
Compare
Owner
Author
|
/gemini_review |
thiyaguk09
changed the title
thiyaguk09
force-pushed
the
storage-node-18
branch
3 times, most recently
from
da2ee2d to
b4ee48b
Compare
thiyaguk09
force-pushed
the
storage-node-18
branch
4 times, most recently
from
82db716 to
b2e12e7
Compare
thiyaguk09
force-pushed
the
node18/system-test
branch
from
cdb8f09 to
3bef808
Compare
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
011f5b5 to
1ae557f
Compare
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
1ae557f to
cc411a0
Compare
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
fca0d9f to
9010041
Compare
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
eacb087 to
0c58a9a
Compare
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
0c58a9a to
fe44861
Compare
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
fe44861 to
0a4f5ac
Compare
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
0a4f5ac to
e3288e3
Compare
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
e3288e3 to
1fba172
Compare
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
1fba172 to
d4b912f
Compare
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
d4b912f to
c0a6220
Compare
thiyaguk09
force-pushed
the
storage-node-18
branch
from
c0a6220 to
0f2652b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕