Repository navigation
[pull] develop from frappe:develop - #442
Merged
Merged
Conversation
…issing auto_update_last_sync
The PWA fetched frappe.translate.load_all_translations, which no longer exists in frappe v17. The request threw, the catch swallowed it, and `messages` stayed empty - so the app rendered untranslated English no matter what language the user or the site was set to. v17 exposes frappe.translate.get_boot_translations instead. It is a whitelisted method, so its payload arrives under `message`; unwrap it. Also read the cache-busting token from boot.translations_version, the key the server actually sends - translations_hash was always undefined and silently fell through to Math.random(), defeating the HTTP cache on every load.
…ift-absent fix: mark absent for overlapping shift assignments in auto attendance
…-reports fix: reset hardcoded letter head on reports
…e_absent_marking # Conflicts: # hrms/hr/doctype/shift_type/shift_type.py
fix(pwa): load translations from the endpoint frappe v17 exposes
…marking feat(shift_type): add configurable option to mark absent on same day
Leave Period has no field that links back to Employee Grade, so the connection could never show any records. It only added an empty card to the Employee Grade form.
…om-employee-grade-connections fix: remove Leave Period from Employee Grade connections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )