Repository navigation
Cross-thread backward (#78) - #79
Merged
Merged
Conversation
…#78) Forward on one thread then .backward() on another raised 'Trying to backward through the graph a second time': the eager tape was thread_local, so the backward thread found none. Each thread still records into its own tape, now an Arc<Mutex> also listed in a process-wide TAPES table; _eager_backward asks its own tape first and otherwise takes the tape (try_lock, never blocking under the GIL) that holds the output. Independent trainers never touch each other's tapes. Door path unchanged; recording pays one uncontended lock per op (not measured). test_threadstate: two cross-thread tests red on the old shim with the misnamed error, green now; a concurrent-trainers guard green on both.
Member
Author
|
Recording-path cost, A/B on the macOS host, 3 interleaved rounds:
|
Contributor
Gate on CI (issue #24)Full gate: 126 suites = 118 run on at least one CI runner + 8 local-only. The local gate (
Local-only: verified by no CI runner (8)
Suites that verified nothing, or failed, on a runner
Every suite, every runner
A SKIP is unverified on that runner, never passed. UNVERIFIED means the suite ran and every one of its tests skipped by name. |
Member
Author
|
CI evidence (run 37329272870, 7c571d5): linux gate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78. Based on #77 (feat/thread-state), so merge #77 first.
Defect fixed
.backward()on another now gives upstream's gradient. Before, it raised the misnamed "backward through the graph a second time".try_lock, never blocking).Test added
tests/api/test_threadstate.py+3:Gate (worktree, local)
build.pyself-test suites that need.caches/;test_anedecode, whereMLComputePlanreturned "internal failure". Rerun alone twice: 10 ok both times. This is the CoreML drift recorded in AGENTS.md §13.3.Not done