Repository navigation
Test: Run against the binder that translates names itself, and pin that both rules agree - #80
Merged
Merged
Conversation
…at both rules agree python-multiplatform #131 (develop 452cc807) restores snake_case names and keywords in the binder, by this package's rule. Step 1 of handing that back: this suite against #131, unchanged, gives 251 passed and 1 failed. The failure is a test that assumed a binder without describe_member refuses a snake_case method keyword; the binder now accepts it itself, so the test skips there. A new test pins that the binder's python_name and this package's agree on names that test the rule (acronyms, overload suffixes, upper-case names); it skips on a binder that renames nothing. test added: TheBindersNamingRuleIsThisPackages (11 names). test changed: test_a_snake_case_keyword_is_the_binders_refusal skips on #131. Suite with python-multiplatform 452cc807 (#131), main checkout: 253 passed, 1 skipped. The older sibling checkout is also run. Refs #79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #79 (step 1 of 5)
Against python-multiplatform #131, this suite unchanged gives 251 passed, 1 failed. The failing test assumed a refusal that the binder no longer makes, so it now skips there. Test added: both naming rules agree on 11 names that exercise the rule.