-
Notifications
You must be signed in to change notification settings - Fork 637
Version Packages #8622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #8622
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughRemoved 14 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (23)
💤 Files with no reviewable changes (15)
🚧 Files skipped from review as they are similar to previous changes (5)
🧰 Additional context used📓 Path-based instructions (2)**/*.{js,jsx,ts,tsx,json}📄 CodeRabbit inference engine (AGENTS.md)
Files:
packages/thirdweb/package.json📄 CodeRabbit inference engine (CLAUDE.md)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🔇 Additional comments (3)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @packages/thirdweb/CHANGELOG.md:
- Around line 3-12: The changelog entry has a stray trailing double-quote after
"bridge widgets" in the 5.117.0 Minor Changes section; edit the CHANGLEOG.md
entry (the line containing '- Remove in-app wallet from default wallet list for
bridge widgets"') and delete the extra '"' so the sentence ends with ...bridge
widgets), leaving all other text and links unchanged.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (22)
.changeset/dirty-breads-swim.md.changeset/dry-wasps-love.md.changeset/eager-loops-obey.md.changeset/easy-teams-agree.md.changeset/etherlink-shadownet-chain.md.changeset/heavy-clowns-stay.md.changeset/ninety-trains-tell.md.changeset/plain-maps-care.md.changeset/short-wasps-show.md.changeset/sixty-clubs-fix.md.changeset/social-ads-arrive.md.changeset/two-pandas-knock.md.changeset/violet-needles-fly.md.changeset/yummy-squids-rush.mdapps/wagmi-demo/CHANGELOG.mdapps/wagmi-demo/package.jsonpackages/nebula/CHANGELOG.mdpackages/nebula/package.jsonpackages/thirdweb/CHANGELOG.mdpackages/thirdweb/package.jsonpackages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
💤 Files with no reviewable changes (14)
- .changeset/yummy-squids-rush.md
- .changeset/easy-teams-agree.md
- .changeset/etherlink-shadownet-chain.md
- .changeset/sixty-clubs-fix.md
- .changeset/plain-maps-care.md
- .changeset/ninety-trains-tell.md
- .changeset/eager-loops-obey.md
- .changeset/violet-needles-fly.md
- .changeset/dirty-breads-swim.md
- .changeset/short-wasps-show.md
- .changeset/dry-wasps-love.md
- .changeset/social-ads-arrive.md
- .changeset/two-pandas-knock.md
- .changeset/heavy-clowns-stay.md
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{js,jsx,ts,tsx,json}
📄 CodeRabbit inference engine (AGENTS.md)
Biome governs formatting and linting; its rules live in biome.json. Run
pnpm fix&pnpm lintbefore committing, ensure there are no linting errors
Files:
packages/nebula/package.jsonpackages/wagmi-adapter/package.jsonpackages/thirdweb/package.jsonapps/wagmi-demo/package.json
packages/thirdweb/package.json
📄 CodeRabbit inference engine (CLAUDE.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/thirdweb/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Size
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (7)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: LGTM!The new version entry follows the existing changelog format. Empty entries are expected for dependency-only version bumps generated by Changesets.
apps/wagmi-demo/package.json (1)
4-4: LGTM!Version bump to 0.0.46 is consistent with the accompanying changelog entry documenting the dependency updates to thirdweb@5.117.0 and @thirdweb-dev/wagmi-adapter@0.2.201.
packages/thirdweb/package.json (1)
433-433: LGTM!Minor version bump to 5.117.0 correctly reflects the feature changes documented in the changelog, including the removal of in-app wallet from the default wallet list and various patch improvements.
packages/wagmi-adapter/package.json (1)
59-59: LGTM!Version bump to 0.2.201 aligns with the changelog entry. The
thirdwebpeer dependency range (^5.85.0) correctly accommodates the new thirdweb@5.117.0 release.packages/nebula/package.json (1)
60-60: LGTM!Patch version bump to 0.2.104 is appropriate for the thirdweb dependency update. The
workspace:*reference ensures compatibility with the newly released thirdweb@5.117.0.packages/nebula/CHANGELOG.md (1)
3-9: LGTM! Changelog entry is properly formatted.The new version entry for 0.2.104 correctly documents the dependency update to thirdweb@5.117.0 and follows the established changelog format.
apps/wagmi-demo/CHANGELOG.md (1)
3-10: LGTM! Changelog entry is properly formatted.The new version entry for 0.0.46 correctly documents the dependency updates to thirdweb@5.117.0 and @thirdweb-dev/wagmi-adapter@0.2.201, and follows the established changelog format.
| ## 5.117.0 | ||
|
|
||
| ### Minor Changes | ||
|
|
||
| - [#8579](https://github.com/thirdweb-dev/js/pull/8579) [`304e4e5`](https://github.com/thirdweb-dev/js/commit/304e4e5be860e4989abf0493cb737f46e050a697) Thanks [@MananTank](https://github.com/MananTank)! - Remove in-app wallet from default wallet list for bridge widgets" | ||
|
|
||
| ### Patch Changes | ||
|
|
||
| - [#8621](https://github.com/thirdweb-dev/js/pull/8621) [`8d4b6a1`](https://github.com/thirdweb-dev/js/commit/8d4b6a1fea53013cbdbe9f450d00470b2f8d3761) Thanks [@MananTank](https://github.com/MananTank)! - Add `amountEditable` and `tokenEditable` props on `BuyWidget` component to disable token selection and token amount editing | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix stray trailing quote in changelog entry (renders incorrectly).
Line 7 ends with an extra " after bridge widgets, which will show up in rendered release notes.
Proposed fix
-- [#8579](https://github.com/thirdweb-dev/js/pull/8579) [`304e4e5`](https://github.com/thirdweb-dev/js/commit/304e4e5be860e4989abf0493cb737f46e050a697) Thanks [@MananTank](https://github.com/MananTank)! - Remove in-app wallet from default wallet list for bridge widgets"
+- [#8579](https://github.com/thirdweb-dev/js/pull/8579) [`304e4e5`](https://github.com/thirdweb-dev/js/commit/304e4e5be860e4989abf0493cb737f46e050a697) Thanks [@MananTank](https://github.com/MananTank)! - Remove in-app wallet from default wallet list for bridge widgets🤖 Prompt for AI Agents
In @packages/thirdweb/CHANGELOG.md around lines 3 - 12, The changelog entry has
a stray trailing double-quote after "bridge widgets" in the 5.117.0 Minor
Changes section; edit the CHANGLEOG.md entry (the line containing '- Remove
in-app wallet from default wallet list for bridge widgets"') and delete the
extra '"' so the sentence ends with ...bridge widgets), leaving all other text
and links unchanged.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8622 +/- ##
=======================================
Coverage 52.97% 52.97%
=======================================
Files 932 932
Lines 62270 62270
Branches 4095 4096 +1
=======================================
Hits 32987 32987
Misses 29184 29184
Partials 99 99
🚀 New features to boost your workflow:
|
f02fff6 to
b992bb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @packages/thirdweb/CHANGELOG.md:
- Line 7: The changelog entry on CHANGELOG.md contains a stray trailing
double-quote at the end of the line referencing PR #8579/commit 304e4e5; remove
the extra `"` character so the entry reads correctly (ensure the line for
"[#8579] [`304e4e5`] Thanks [@MananTank] - Remove in-app wallet from default
wallet list for bridge widgets" has no trailing quote and matches surrounding
entry formatting).
🧹 Nitpick comments (2)
apps/wagmi-demo/package.json (1)
28-28: Consider pinning@wagmi/clito a specific version.Using
"latest"for dependencies can lead to non-reproducible builds. While this is a private demo app with lower risk, pinning to a specific version would improve build consistency.packages/thirdweb/CHANGELOG.md (1)
5-38: (Optional) Normalize changelog style: “UI” capitalization + punctuation consistency.A few entries read slightly inconsistent (e.g., “wide connect ui” vs “UI”, some bullets ending with
.and others not). Consider normalizing within the 5.117.0 section for a more polished release note.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (22)
.changeset/dirty-breads-swim.md.changeset/dry-wasps-love.md.changeset/eager-loops-obey.md.changeset/easy-teams-agree.md.changeset/etherlink-shadownet-chain.md.changeset/heavy-clowns-stay.md.changeset/ninety-trains-tell.md.changeset/plain-maps-care.md.changeset/short-wasps-show.md.changeset/sixty-clubs-fix.md.changeset/social-ads-arrive.md.changeset/two-pandas-knock.md.changeset/violet-needles-fly.md.changeset/yummy-squids-rush.mdapps/wagmi-demo/CHANGELOG.mdapps/wagmi-demo/package.jsonpackages/nebula/CHANGELOG.mdpackages/nebula/package.jsonpackages/thirdweb/CHANGELOG.mdpackages/thirdweb/package.jsonpackages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
💤 Files with no reviewable changes (14)
- .changeset/yummy-squids-rush.md
- .changeset/short-wasps-show.md
- .changeset/sixty-clubs-fix.md
- .changeset/two-pandas-knock.md
- .changeset/eager-loops-obey.md
- .changeset/etherlink-shadownet-chain.md
- .changeset/dry-wasps-love.md
- .changeset/dirty-breads-swim.md
- .changeset/social-ads-arrive.md
- .changeset/ninety-trains-tell.md
- .changeset/easy-teams-agree.md
- .changeset/heavy-clowns-stay.md
- .changeset/plain-maps-care.md
- .changeset/violet-needles-fly.md
🚧 Files skipped from review as they are similar to previous changes (4)
- packages/wagmi-adapter/package.json
- packages/wagmi-adapter/CHANGELOG.md
- packages/nebula/package.json
- packages/thirdweb/package.json
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{js,jsx,ts,tsx,json}
📄 CodeRabbit inference engine (AGENTS.md)
Biome governs formatting and linting; its rules live in biome.json. Run
pnpm fix&pnpm lintbefore committing, ensure there are no linting errors
Files:
apps/wagmi-demo/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Lint Packages
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
apps/wagmi-demo/CHANGELOG.md (1)
3-9: LGTM!The changelog entry for version 0.0.46 correctly documents the dependency updates to
thirdweb@5.117.0and@thirdweb-dev/wagmi-adapter@0.2.201, aligning with the PR objectives. The commit references are properly linked.apps/wagmi-demo/package.json (1)
4-4: LGTM!The version bump to 0.0.46 is consistent with the changelog entry and aligns with the release workflow.
packages/nebula/CHANGELOG.md (1)
3-9: LGTM! Changelog entry follows the established pattern.The new version section for 0.2.104 is correctly formatted and documents the dependency update to thirdweb@5.117.0. The structure is consistent with all previous changelog entries, and the version ordering is correct.
|
|
||
| ### Minor Changes | ||
|
|
||
| - [#8579](https://github.com/thirdweb-dev/js/pull/8579) [`304e4e5`](https://github.com/thirdweb-dev/js/commit/304e4e5be860e4989abf0493cb737f46e050a697) Thanks [@MananTank](https://github.com/MananTank)! - Remove in-app wallet from default wallet list for bridge widgets" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix stray quote at end of changelog entry (typo).
Line 7 ends with an extra " which will ship to users verbatim.
Proposed fix
-- [#8579](https://github.com/thirdweb-dev/js/pull/8579) [`304e4e5`](https://github.com/thirdweb-dev/js/commit/304e4e5be860e4989abf0493cb737f46e050a697) Thanks [@MananTank](https://github.com/MananTank)! - Remove in-app wallet from default wallet list for bridge widgets"
+- [#8579](https://github.com/thirdweb-dev/js/pull/8579) [`304e4e5`](https://github.com/thirdweb-dev/js/commit/304e4e5be860e4989abf0493cb737f46e050a697) Thanks [@MananTank](https://github.com/MananTank)! - Remove in-app wallet from default wallet list for bridge widgets📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - [#8579](https://github.com/thirdweb-dev/js/pull/8579) [`304e4e5`](https://github.com/thirdweb-dev/js/commit/304e4e5be860e4989abf0493cb737f46e050a697) Thanks [@MananTank](https://github.com/MananTank)! - Remove in-app wallet from default wallet list for bridge widgets" | |
| - [#8579](https://github.com/thirdweb-dev/js/pull/8579) [`304e4e5`](https://github.com/thirdweb-dev/js/commit/304e4e5be860e4989abf0493cb737f46e050a697) Thanks [@MananTank](https://github.com/MananTank)! - Remove in-app wallet from default wallet list for bridge widgets |
🤖 Prompt for AI Agents
In @packages/thirdweb/CHANGELOG.md at line 7, The changelog entry on
CHANGELOG.md contains a stray trailing double-quote at the end of the line
referencing PR #8579/commit 304e4e5; remove the extra `"` character so the entry
reads correctly (ensure the line for "[#8579] [`304e4e5`] Thanks [@MananTank] -
Remove in-app wallet from default wallet list for bridge widgets" has no
trailing quote and matches surrounding entry formatting).
b992bb5 to
ac482c1
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
thirdweb@5.117.0
Minor Changes
304e4e5Thanks @MananTank! - Remove in-app wallet from default wallet list for bridge widgets"Patch Changes
#8621
8d4b6a1Thanks @MananTank! - AddamountEditableandtokenEditableprops onBuyWidgetcomponent to disable token selection and token amount editing#8573
9c04b3fThanks @MananTank! - More reliable list of chains shown in token selection UI in SwapWidget based on origin and destination chain selections#8552
5ec84bdThanks @MananTank! - Token Selection UX improvements in SwapWidget#8607
01004e8Thanks @MananTank! - TransactionWidget UI improvements#8623
36ff327Thanks @joaquim-verges! - Support x402 v2#8611
26a9153Thanks @Yash094! - Add Etherlink Shadownet testnet chain (chain ID 127823)#8580
0ff8b9fThanks @MananTank! - Move directly to token selection screen after connecting wallet in "Choose Payment" screen instead of showing the "Choose Payment" screen again after connecting wallet in bridge widgets#8551
31e24f1Thanks @MananTank! - Alphabetically sort the chains in SwapWidget UI#8578
fdd2557Thanks @MananTank! - Remove fiat price shown in the button inCheckoutWidgetto avoid showing it twice in the UI.#8556
151127dThanks @MananTank! - Update in-app wallet icon in wide connect ui#8617
5766c90Thanks @jelilat! - Support for x402 payment-required headers#8631
f68c2c6Thanks @MananTank! - Add Last Used badge in Connect UI to highlight the last used sign-in method#8608
a3ff757Thanks @MananTank! - Add token details screen in token selection UI in SwapWidget, BridgeWidget#8553
38f4a89Thanks @MananTank! - Fix Spinner animation not working sometimes in Next.js#8576
56a1c0aThanks @MananTank! - Payment Details UI improvements for bridge widget components@thirdweb-dev/nebula@0.2.104
Patch Changes
8d4b6a1,9c04b3f,5ec84bd,01004e8,36ff327,26a9153,0ff8b9f,31e24f1,304e4e5,fdd2557,151127d,5766c90,f68c2c6,a3ff757,38f4a89,56a1c0a]:@thirdweb-dev/wagmi-adapter@0.2.201
wagmi-inapp@0.0.46
Patch Changes
8d4b6a1,9c04b3f,5ec84bd,01004e8,36ff327,26a9153,0ff8b9f,31e24f1,304e4e5,fdd2557,151127d,5766c90,f68c2c6,a3ff757,38f4a89,56a1c0a]:PR-Codex overview
This PR primarily focuses on updating version numbers across several packages, along with significant dependency updates and changelog entries for multiple components, including
thirdweb,wagmi-demo, andwagmi-adapter.Detailed summary
.mdfiles in.changeset.packages/thirdweb/package.jsonfrom5.116.1to5.117.0.apps/wagmi-demo/package.jsonfrom0.0.45to0.0.46.packages/nebula/package.jsonfrom0.2.103to0.2.104.packages/wagmi-adapter/package.jsonfrom0.2.200to0.2.201.nebula,wagmi-demo, andthirdweb, detailing patch changes and dependency updates.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.