Enable multiple ref params for bytes input by kumaryash90 · Pull Request #8610 · thirdweb-dev/js

kumaryash90 · 2026-01-07T11:59:41Z

PR-Codex overview

This PR focuses on modifying the Button component in the decoded-input-set.tsx file to conditionally disable it based on the param.type and the length of fields.

Detailed summary

The Button component now has a condition for the disabled prop.
It disables the button when param.type is "bytes" and fields.length is greater than or equal to 1.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Bug Fixes
- Fixed an issue in the contract publish form where the Add Parameter control was incorrectly restricted for byte-type parameters. Users can now add multiple byte parameters without encountering the previous restriction, improving form flexibility and workflow.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

changeset-bot · 2026-01-07T11:59:46Z

⚠️ No Changeset found

Latest commit: 0382d42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2026-01-07T11:59:47Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
thirdweb-www	Ready	Preview, Comment	Jan 8, 2026 3:31pm

4 Skipped Deployments

Project	Deployment	Updated (UTC)
docs-v2	Skipped	Jan 8, 2026 3:31pm
nebula	Skipped	Jan 8, 2026 3:31pm
thirdweb_playground	Skipped	Jan 8, 2026 3:31pm
wallet-ui	Skipped	Jan 8, 2026 3:31pm

coderabbitai · 2026-01-07T12:00:01Z

Walkthrough

Removed a conditional guard that disabled the "Add Parameter" button when the parameter type was bytes and existing fields were present. The button is now always enabled, permitting unrestricted addition of parameters regardless of type or field count.

Changes

Cohort / File(s)	Summary
Button State Logic `apps/dashboard/src/app/(app)/(dashboard)/contracts/publish/[publish_uri]/contract-publish-form/decoded-bytes-input/decoded-input-set.tsx`	Removed conditional that disabled Add Parameter button for `bytes`-type parameters when fields existed. Button remains enabled in all cases.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is incomplete and does not follow the required template structure. It lacks required sections like issue tag, notes for reviewer, and testing instructions.	Add the Linear issue tag (TEAM-0000 format), provide notes for reviewers about the behavioral change, and include testing instructions for validating the fix.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: enabling multiple reference parameters for bytes input by removing the conditional disable on the Add Parameter button.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2aac3c7 and 0382d42.

📒 Files selected for processing (1)

apps/dashboard/src/app/(app)/(dashboard)/contracts/publish/[publish_uri]/contract-publish-form/decoded-bytes-input/decoded-input-set.tsx

💤 Files with no reviewable changes (1)

apps/dashboard/src/app/(app)/(dashboard)/contracts/publish/[publish_uri]/contract-publish-form/decoded-bytes-input/decoded-input-set.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: Unit Tests
GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: Lint Packages
GitHub Check: Size
GitHub Check: Analyze (javascript)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-01-07T12:02:56Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.02%. Comparing base (d35cad8) to head (0382d42).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8610   +/-   ##
=======================================
  Coverage   53.02%   53.02%           
=======================================
  Files         924      924           
  Lines       61726    61726           
  Branches     4035     4035           
=======================================
  Hits        32730    32730           
  Misses      28898    28898           
  Partials       98       98

Flag	Coverage Δ
packages	`53.02% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-01-07T12:05:30Z

size-limit report 📦

Path	Size
@thirdweb-dev/nexus (esm)	105.66 KB (0%)
@thirdweb-dev/nexus (cjs)	319.47 KB (0%)

kumaryash90 · 2026-01-08T15:11:55Z

Merge activity

Jan 8, 3:11 PM UTC: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jan 8, 3:23 PM UTC: kumaryash90 added this pull request to the Graphite merge queue.
Jan 8, 3:32 PM UTC: Merged by the Graphite merge queue.

--- ## PR-Codex overview This PR focuses on modifying the `Button` component in the `decoded-input-set.tsx` file to enhance its functionality based on certain conditions related to `param.type` and `fields`. ### Detailed summary - Updated the `Button` component to disable it when `param.type` is "bytes" and `fields.length` is 1 or more. - Maintained the existing `onClick` functionality to append a new input with a default value of an empty string. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`   ## Summary by CodeRabbit * **Bug Fixes** * Fixed an issue in the contract publish form where the Add Parameter button was incorrectly disabled when working with bytes parameters. Users can now add multiple bytes parameters without restriction. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>

kumaryash90 requested review from a team as code owners January 7, 2026 11:59

github-actions Bot added the Dashboard Involves changes to the Dashboard. label Jan 7, 2026

github-actions Bot assigned kumaryash90 Jan 7, 2026

vercel Bot deployed to Preview – thirdweb-www January 7, 2026 12:07 View deployment

joaquim-verges approved these changes Jan 7, 2026

View reviewed changes

kumaryash90 added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 8, 2026

vercel Bot deployed to Preview – wallet-ui January 8, 2026 15:12 View deployment

vercel Bot deployed to Preview – thirdweb_playground January 8, 2026 15:12 View deployment

vercel Bot deployed to Preview – nebula January 8, 2026 15:13 View deployment

vercel Bot deployed to Preview – thirdweb-www January 8, 2026 15:19 View deployment

vercel Bot deployed to Preview – docs-v2 January 8, 2026 15:23 View deployment

graphite-app Bot force-pushed the yash/fix-ref-publish branch from e2a5adc to 0382d42 Compare January 8, 2026 15:23

vercel Bot temporarily deployed to Preview – nebula January 8, 2026 15:24 Inactive

vercel Bot temporarily deployed to Preview – docs-v2 January 8, 2026 15:24 Inactive

vercel Bot temporarily deployed to Preview – wallet-ui January 8, 2026 15:24 Inactive

vercel Bot temporarily deployed to Preview – thirdweb_playground January 8, 2026 15:24 Inactive

vercel Bot deployed to Preview – thirdweb-www January 8, 2026 15:31 View deployment

graphite-app Bot merged commit 0382d42 into main Jan 8, 2026
25 checks passed

graphite-app Bot deleted the yash/fix-ref-publish branch January 8, 2026 15:32

graphite-app Bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Jan 8, 2026

vercel Bot temporarily deployed to Production – wallet-ui January 8, 2026 15:32 Inactive

vercel Bot temporarily deployed to Production – docs-v2 January 8, 2026 15:32 Inactive

vercel Bot temporarily deployed to Production – thirdweb_playground January 8, 2026 15:32 Inactive

vercel Bot temporarily deployed to Production – nebula January 8, 2026 15:32 Inactive

vercel Bot deployed to Production – thirdweb-www January 8, 2026 15:40 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable multiple ref params for bytes input#8610

Enable multiple ref params for bytes input#8610
graphite-app[bot] merged 1 commit into
mainfrom
yash/fix-ref-publish

kumaryash90 commented Jan 7, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jan 7, 2026 •

edited

Loading

Review ran into problems

Uh oh!

codecov Bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

kumaryash90 commented Jan 8, 2026 •

edited by graphite-app Bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kumaryash90 commented Jan 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel Bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Review ran into problems

Uh oh!

codecov Bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

kumaryash90 commented Jan 8, 2026 • edited by graphite-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kumaryash90 commented Jan 7, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Jan 7, 2026 •

edited

Loading

vercel Bot commented Jan 7, 2026 •

edited

Loading

coderabbitai Bot commented Jan 7, 2026 •

edited

Loading

codecov Bot commented Jan 7, 2026 •

edited

Loading

github-actions Bot commented Jan 7, 2026 •

edited

Loading

kumaryash90 commented Jan 8, 2026 •

edited by graphite-app Bot

Loading