ipc4: base_fw: Make Astate handler a function#10528
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Feb 6, 2026
Merged
ipc4: base_fw: Make Astate handler a function#10528lgirdwood merged 1 commit intothesofproject:mainfrom
lgirdwood merged 1 commit intothesofproject:mainfrom
Conversation
wjablon1
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Moving Astate handler to a function because STATIC_ASSERT cannot be used as the first instruction of switch/case block Signed-off-by: Wojciech Jablonski <wojciech.jablonski@intel.com>
lgirdwood
approved these changes
Feb 6, 2026
singalsu
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out the current implementation of STATIC_ASSERT cannot be used as the first instruction of switch/case for all the supported compilers. Initially I wanted to fix the macro itself but it’s not that easy (mainly because the macro is used in both global and local contexts). So I decided to move the code to a separate function (this should work because we already have similar occurrences).