Fix the Handler argument types missing request.params#27
Open
opl- wants to merge 1 commit intotherne:masterfrom
Open
Fix the Handler argument types missing request.params#27opl- wants to merge 1 commit intotherne:masterfrom
opl- wants to merge 1 commit intotherne:masterfrom
Conversation
Also fixes the default value for `KoaCompatibleMiddleware`'s generic type `CustomT` (custom context) being wrong. The previous type was equivalent anyway, but it's still a misleading hint for developers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inferred types for
Handlers were missing thectx.request.paramsproperty, resulting in an error when attempting to access them.Also fixes the default value for
KoaCompatibleMiddleware's generic typeCustomT(custom context) being wrong. The previous type was equivalent anyway, but it's still a misleading hint for developers.Fixes #26