Fix macOS release OpenAL dependency audit - #155
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first
v0.13.0draft build exposed a release-blocking mismatch in the redundant macOS Mach-O audit. The package correctly embedded OpenAL Soft atopenQ4.app/Contents/Frameworks/libopenal.1.dylib, but the workflow rejected the client's exact@rpath/libopenal.1.dylibreference as an unbundled dependency.This allows only that exact
@rpathreference and only when the expected runtime exists. The embedded library is added to the same architecture, dependency, code-signature, and install-name checks as the app and modules. Arbitrary@rpathand other non-system dependencies remain rejected.Validation:
python tools/tests/macos_openal_provider_policy.pypython tools/tests/release_tooling_safety.pypython tools/tests/macos_metal_bridge.pypython tools/tests/source_charset_integrity.pypython -m py_compile tools/tests/macos_openal_provider_policy.pypython tools/validation/openq4_validate.py macos-static --dry-rungit diff --checkThe failed draft workflow was cancelled before publication. No release or Discord announcement was created.