Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| std::scoped_lock lock(g_sinkMutex); | ||
| assert(!g_printMessages.empty()); | ||
| assert(!g_errorMessages.empty()); |
There was a problem hiding this comment.
Update thread safety test to drive error sink
The new thread-safety test asserts g_errorMessages is non-empty, but the only logging performed in this test uses worr::Log (lines 64‑67), which routes messages to the print sink only; the error sink is driven exclusively by LoggerError. Because CollectError is never invoked, g_errorMessages will always remain empty and the assertion here fails deterministically. The test needs to call LoggerError (or drop the assertion) to reflect the logger API.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task