Address a race condition with reloading evicted textures by using texture_load_tasks PPL group.#604
Open
noisethanks wants to merge 1 commit into
Conversation
…ture_load_tasks PPL group.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(renderer): make evicted texture reloads thread-safe in MT build
EvictStalledTextures() resets bind to apply_load, which previously
called Load() inline on the render thread. In the MT build this races
D3DX11CreateTextureFromMemory calls on the resource thread pool.
Fix: queue reloads through the existing textures_load_tasks PPL group
(same mechanism _CreateTexture uses for initial loads) rather than
calling Load() inline. bLoading flag prevents duplicate queuing while
a reload is in flight. apply_normal() is called in the interim so the
render thread never touches resources being concurrently created.