Fix Encoding::CompatibilityError in password filtering#132
Merged
Conversation
Contributor
Author
|
Tests should turn green after #133 |
pondrejk
approved these changes
May 18, 2026
pondrejk
approved these changes
May 18, 2026
Member
|
Could you please rebase? |
The SSH stream always returns ASCII-8BIT data, which is incompatible with the UTF-8 regexp built from the password when it contains wide characters. Match in binary encoding on both sides to avoid this. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
rebased |
ofedoren
approved these changes
May 18, 2026
ofedoren
left a comment
ofedoren
left a comment
Member
There was a problem hiding this comment.
Thanks, @adamruzicka and @pondrejk !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SSH stream always returns ASCII-8BIT data, which is incompatible
with the UTF-8 regexp built from the password when it contains
wide characters. Match in binary encoding on both sides to avoid this.
Co-authored-by: Cursor cursoragent@cursor.com