Set upper pulpcore bound to 3.130, to align with other Pulp plugins - #75
Merged
Merged
Conversation
ianballou
force-pushed
the
align-pulpcore-requirement
branch
from
September 16, 2026 16:23
9b8d73c to
c102a5d
Compare
Odilhao
approved these changes
Sep 16, 2026
evgeni
approved these changes
Sep 16, 2026
Member
|
Can you kick one release for us @evgeni ? Looks like I don't have permission to run that. |
Member
|
Running. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our plugin doesn't need to be so strict about the upper bound, Pulpcore doesn't change that often. Instead they follow a breaking change schedule. If you look at other plugins, right now you'll see an upper bound of 3.130. We should do the same. It is tedious to have to do these y-release bumps so often.
For example: https://github.com/pulp/pulp_container/blob/54b396628fe36de29909ddd95f8a41c3486fd924/pyproject.toml#L27
See https://pulpproject.org/pulpcore/docs/user/learn/pulp-versioning/
After this is out, I'd like to request another release. We are aiming to go for Pulpcore 3.108 after all, since Pulp has come out with it since we've been prepping to upgrade Pulp. Haven't done enough work to justify not going to 3.108.
📜 Checklist
See: Pull Request Walkthrough