Skip to content

Fixes #39411 - Display locked field as yes/no in job template info#65

Merged
ofedoren merged 1 commit into
theforeman:masterfrom
lhellebr:39411-fix-locked-field-boolean
Jun 11, 2026
Merged

Fixes #39411 - Display locked field as yes/no in job template info#65
ofedoren merged 1 commit into
theforeman:masterfrom
lhellebr:39411-fix-locked-field-boolean

Conversation

@lhellebr

Copy link
Copy Markdown
Contributor

The locked field in job-template info was missing the Fields::Boolean type annotation, causing it to display raw true/false values instead of yes/no like other template types (e.g. partition tables).

Redmine: https://projects.theforeman.org/issues/39411

Comment thread test/unit/job_template_test.rb Outdated
out, _err = capture_io do
cmd.run(['--id=1'])
end
_(out).must_match(/Locked:\s+(yes|no)/)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we know which option it will actually be?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, no :)
I wasn't sure whether to code this so the template can change, or hardcode it, and it seems you prefer hardcoding. I'll update it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@lhellebr lhellebr force-pushed the 39411-fix-locked-field-boolean branch from 9a8eb08 to 24afbbe Compare June 10, 2026 14:02
@adamruzicka

Copy link
Copy Markdown
Contributor

qemu: uncaught target signal 11 (Segmentation fault) - core dumped
/var/tmp/rpm-tmp.zp4lh7: line 47: 115 Segmentation fault (core dumped) CONFIGURE_ARGS="--with-cflags='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64-v2 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection' --with-cxxflags='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64-v2 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection' --with-ldflags='-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 ' $CONFIGURE_ARGS" gem install -V --local --build-root . --force --document=ri,rdoc hammer_cli_foreman_remote_execution-0.4.3.gem
error: Bad exit status from /var/tmp/rpm-tmp.zp4lh7 (%build)

looks like copr is having a moment

@adamruzicka adamruzicka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, let's wait for robottelo to bless this.

@ofedoren

Copy link
Copy Markdown
Member

/packit build

@ofedoren

Copy link
Copy Markdown
Member

robobless: SatelliteQE/robottelo#21786 (comment)

@ofedoren ofedoren left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lhellebr and @adamruzicka !

@ofedoren ofedoren merged commit 5bcc077 into theforeman:master Jun 11, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants