Skip to content

Fixes #39013 - add the locked parameter to job info#60

Merged
adamruzicka merged 1 commit into
theforeman:masterfrom
pondrejk:locked-param
Jan 21, 2026
Merged

Fixes #39013 - add the locked parameter to job info#60
adamruzicka merged 1 commit into
theforeman:masterfrom
pondrejk:locked-param

Conversation

@pondrejk

Copy link
Copy Markdown
Contributor

No description provided.

@ofedoren

Copy link
Copy Markdown
Member

Thanks, @pondrejk, the test failures should be resolved in latest master branch, could you please rebase?

@ofedoren

Copy link
Copy Markdown
Member

Also, we tend to create a RM ticket to better track effort, especially if something is a part of a bigger task.

Could you please create it https://projects.theforeman.org/projects/foreman_remote_execution/issues/new and include the number in the commit message like Fixes #12345 - Add locked field for JobTemplate info

@pondrejk pondrejk changed the title adding the locked parameter to job info Fixes #39013 - adding the locked parameter to job info Jan 20, 2026
@adamruzicka

adamruzicka commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

@adamruzicka

Copy link
Copy Markdown
Contributor

And for the sake of completeness, checked with packit, all good.

# rpm -q rubygem-hammer_cli_foreman_remote_execution
rubygem-hammer_cli_foreman_remote_execution-0.3.4-1.20260120141651693759.pr60.3.g9604e6c.el9.noarch

# hammer job-template info --id 225 | grep Locked
Locked:        true

# hammer job-template info --id 253 | grep Locked
Locked:        false

@pondrejk pondrejk changed the title Fixes #39013 - adding the locked parameter to job info Fixes #39013 - add the locked parameter to job info Jan 21, 2026
@adamruzicka adamruzicka merged commit 77cbcd8 into theforeman:master Jan 21, 2026
11 checks passed
@adamruzicka

Copy link
Copy Markdown
Contributor

Thank you @pondrejk & @ofedoren !

@aneta-petrova

Copy link
Copy Markdown
Member

Verified on snap 158.0 with packit build, rubygem-hammer_cli_foreman_remote_execution-0.3.4-1.20260120141651693759.pr60.3.g9604e6c.el9.noarch.

# hammer job-template info --id 225
ID:            225
Name:          Upload profile - Katello Script Default
Job Category:  Katello
Provider:      script
Type:          job_template
Description:   
    
Inputs:        


Locked:        true
Locations:     
    Default Location
Organizations: 
    Default Organization

The hammer job-template command includes line Locked: true, which was previously missing.

This now matches commands hammer webhook-template and hammer template, which also include Locked: true.

The hammer job-template update --locked false command updates the Locked value as expected:

# hammer job-template update --id 225 --locked false
Job template updated

# hammer job-template info --id 225
ID:            225
Name:          Upload profile - Katello Script Default
Job Category:  Katello
Provider:      script
Type:          job_template
Description:   
    
Inputs:        


Locked:        false
Locations:     
    Default Location
Organizations: 
    Default Organization

@lhellebr

Copy link
Copy Markdown
Contributor

/packit build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants