Remove the duplicate HTTPS entry#558
Open
amolpati30 wants to merge 1 commit into
Open
Conversation
jeremylenz
approved these changes
Jun 11, 2026
ehelms
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
The development environment info message displayed after a successful forge deploy-dev shows a malformed URL for the Foreman UI. The variable foreman_development_url is defined in
development/roles/foreman_development/defaults/main.yaml as:main.yaml
foreman_development_url: "http://{{ ansible_facts['fqdn'] }}:{{ foreman_development_rails_port }}This variable already includes the
http://scheme. However, the info message template indeploy-dev.yamlwas incorrectly prepending https:// in front of it:Foreman UI: https://{{ foreman_development_url }}This produced a double-scheme URL like https://http://foremanctl.example.com:3000, which is invalid and confusing for users.
What are the changes introduced in this pull request?
A single-line fix in
development/playbooks/deploy-dev/deploy-dev.yaml:remove the hardcodedhttps://prefix from the Foreman UI URL in the post-deploy info message, so the variable foreman_development_url is used directly (which already contains the correct http:// scheme).Before:
After:
This produces the correct URL: http://:3000.
How to test this pull request
Steps to reproduce:
Deploy the development environment:
./forge deploy-devAccess URLs:
Confirm the URL is not displayed as https://http://:3000.
Fixes #454
Checklist