Skip to content

Remove the duplicate HTTPS entry#558

Open
amolpati30 wants to merge 1 commit into
theforeman:masterfrom
amolpati30:remove_duplicate_entry_for_foreman_UI_url
Open

Remove the duplicate HTTPS entry#558
amolpati30 wants to merge 1 commit into
theforeman:masterfrom
amolpati30:remove_duplicate_entry_for_foreman_UI_url

Conversation

@amolpati30

@amolpati30 amolpati30 commented Jun 11, 2026

Copy link
Copy Markdown

Why are you introducing these changes? (Problem description, related links)

The development environment info message displayed after a successful forge deploy-dev shows a malformed URL for the Foreman UI. The variable foreman_development_url is defined in development/roles/foreman_development/defaults/main.yaml as:

main.yaml
foreman_development_url: "http://{{ ansible_facts['fqdn'] }}:{{ foreman_development_rails_port }}
This variable already includes the http:// scheme. However, the info message template in deploy-dev.yaml was incorrectly prepending https:// in front of it:

What are the changes introduced in this pull request?

A single-line fix in development/playbooks/deploy-dev/deploy-dev.yaml: remove the hardcoded https:// prefix from the Foreman UI URL in the post-deploy info message, so the variable foreman_development_url is used directly (which already contains the correct http:// scheme).

Before:

  • Foreman UI: https://{{ foreman_development_url }}

After:

  • Foreman UI: {{ foreman_development_url }}
    This produces the correct URL: http://:3000.

How to test this pull request

Steps to reproduce:
Deploy the development environment:

  1. ./forge deploy-dev

  2. Access URLs:

  • Foreman UI: http://:3000
    Confirm the URL is not displayed as https://http://:3000.

Fixes #454

Checklist

  • Tests added/updated (if applicable)
  • Documentation updated (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

http:// is duplicated in development environment info message

3 participants