Fix IOP tests to properly validate service endpoints#544
Open
ehelms wants to merge 1 commit into
Open
Conversation
evgeni
reviewed
Jun 9, 2026
Comment on lines
+31
to
+32
|
|
||
|
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
Comments addressed |
evgeni
requested changes
Jun 11, 2026
evgeni
left a comment
evgeni
left a comment
Member
There was a problem hiding this comment.
One last missing piece, otherwise ACK
evgeni
reviewed
Jun 11, 2026
| result = server.run("curl -f http://localhost:24443/api/ingress 2>/dev/null || echo 'Gateway API ingress not yet responding'") | ||
| assert result.rc == 0 | ||
| result = server.run("curl -s -o /dev/null http://localhost:24443/api/ingress") | ||
| assert result.succeeded |
Member
There was a problem hiding this comment.
These two don't use --fail, which I assume is intentional, but there is no explanation why and it will be confusing the next time we touch this, can you add a comment for that please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
The IOP HTTP endpoint tests had several issues that prevented them from actually validating services:
localhostfor ports not published to the host (only the gateway publishes 24443)|| echofallbacks madercalways 0, so tests passed whether services were up or downif result.succeededguards silently skipped assertions whenpodman runfailed due to missing--networkWhat are the changes introduced in this pull request?
--network=iop-core-networkto allpodman runcurl commands so container DNS resolves|| echofallbacks andif result.succeededguards so failures surface/api/insights/v1/status/live/for advisor,/healthfor remediationsHow to test this pull request
Steps to reproduce:
./foremanctl deploy./forge test --pytest_args="tests/iop/"Checklist