Add Templates feature to foreman-proxy#519
Open
shubhamsg199 wants to merge 2 commits into
Open
Conversation
shubhamsg199
force-pushed
the
templates-feature
branch
from
dcadf66 to
9a7993c
Compare
ehelms
reviewed
May 26, 2026
shubhamsg199
force-pushed
the
templates-feature
branch
3 times, most recently
from
77b2cc9 to
6be7b5b
Compare
stejskalleos
requested changes
Jun 8, 2026
shubhamsg199
force-pushed
the
templates-feature
branch
from
6be7b5b to
26ddc10
Compare
shubhamsg199
force-pushed
the
templates-feature
branch
from
26ddc10 to
215ec14
Compare
shubhamsg199
force-pushed
the
templates-feature
branch
from
215ec14 to
c5bb26e
Compare
Member
|
Does templates need to be in the features.yaml? I do not see how the feature in this PR ensures foreman-proxy gets added. |
Contributor
Author
Yes, templates is declared in features.yaml under the foreman_proxy key (same pattern as bmc). I don't think we have a way to ensure if foreman-proxy gets added. |
shubhamsg199
force-pushed
the
templates-feature
branch
4 times, most recently
from
713b3d9 to
ded1e9b
Compare
Contributor
Author
|
@ehelms Made some updates that ensures foreman-proxy gets added on the feature install. Not sure if that should be part of this PR. |
arvind4501
reviewed
Jun 12, 2026
Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
shubhamsg199
force-pushed
the
templates-feature
branch
from
ded1e9b to
f0ba618
Compare
Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
shubhamsg199
force-pushed
the
templates-feature
branch
from
f0ba618 to
b20b505
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
What are the changes introduced in this pull request?
How to test this pull request
Steps to reproduce:
Checklist