Skip to content

Restore JavaScript CI#71

Open
ekohl wants to merge 1 commit into
theforeman:developfrom
ekohl:restore-js-ci
Open

Restore JavaScript CI#71
ekohl wants to merge 1 commit into
theforeman:developfrom
ekohl:restore-js-ci

Conversation

@ekohl

@ekohl ekohl commented Apr 17, 2024

Copy link
Copy Markdown
Member

Previously it wasn't running, but this also updates it to common CI.

@ekohl

ekohl commented Apr 17, 2024

Copy link
Copy Markdown
Member Author

@MariaAga these are the lint failures you were mentioning yesterday, right? Are these the failures you would expect to see?

@MariaAga

Copy link
Copy Markdown
Member

No, I talked about Unable to resolve path to module 'non-installed-module'.
is the lint supposed to run in /home/runner/work/foreman_google/foreman_google/foreman_google? (3 times plugin name)
I see it as running in 2 time plugin name in foreman core and REX ( lint home/runner/work/foreman_remote_execution/foreman_remote_execution )

@ekohl

ekohl commented Apr 18, 2024

Copy link
Copy Markdown
Member Author

I think that's correct. The working directory appears to be /home/runner/work/foreman_google/foreman_google and within that it clones both foreman and foreman_google. So from the working directory /home/runner/work/foreman_google/foreman_google/foreman_google it should be able to find ../foreman with a full clone.

If you look at REX's CI, it doesn't clone foreman itself, so I wonder how it's able to find Foreman's React code then. Perhaps it's just not checking it then?

@MariaAga

Copy link
Copy Markdown
Member

Most plugins use mocks instead of foremanReact

Previously it wasn't running, but this also updates it to common CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants