Update foreman-maintain health for foremanctl

[aneta-petrova]

What changes are you introducing?

Changing references to foreman-maintain health to foremanctl health.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

To support the transition to containerized Foreman.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

This PR only updates the commands. It does not publish the changes to docs.theforeman.org because I'm only verifying the new commands work, not the procedures as a whole.

Contributor checklists

• I am okay with my commits getting squashed when you merge this PR.
• I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

• Foreman 3.19/Katello 4.21
• Foreman 3.18/Katello 4.20 (Satellite 6.19)
• Foreman 3.17/Katello 4.19
• Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6, 7.7, and 7.8)
• Foreman 3.15/Katello 4.17
• Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
• Foreman 3.13/Katello 4.15 (EL9 only)
• Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
• We do not accept PRs for Foreman older than 3.12.

[github-actions]

The PR preview for 24dd254 is available at theforeman-foreman-documentation-preview-pr-4843.surge.sh

No diff compared to the current base

show diff

[aneta-petrova]

@jafiala Can you please take a look here? This is my first foremanctl PR that updates a foreman-maintain command to its foremanctl equivalent.

This involves introducing a foremanctl-maintain attribute (which has the same value as foremanctl-installer, I think those can be merged after we change the foremanctl build target attribute) and updating the individual occurrences of the commands.

It does not involve exposing the affected guides' foremanctl variants in the list of containerized guides in https://docs.theforeman.org/release/nightly/ because this particular command is spread over multiple procedures and verifying those procedures (and assemblies) as a whole is out of scope (that should come later, as we actually review the whole guides and expose them).

Does this make sense to you?

[maximiliankolb]

diff LGTM

[aneta-petrova]

With the latest commit, I also exposed proc_troubleshooting-permission-issues.adoc in the Upgrading guide. Because all steps in that procedure are being updated for foremanctl, I think that's safe enough to do already. Doing so will ensure the procedure will show up in https://docs.theforeman.org/nightly/Upgrading_Project/index-containerized-katello.html, which is accessible from https://docs.theforeman.org/release/nightly/

[aneta-petrova]

Hi @qcjames53, I think I applied all your feedback. Can you please re-review?

[qcjames53]

I'm sorry about the big delay for re-reviewing this. I'm confident we're finally at a place where there won't be any more param changes on theforeman/foremanctl#521. Sorry to keep changing things; it has been a very involved review process. This will need one more round of fixes and I think we'll be good.

[aneta-petrova]

I moved some feedback to #4928, and applied the feedback for the changes that remained here. @qcjames53 can you please re-review?

[qcjames53]

Absolutely! We surprise merged theforeman/foremanctl#521 today so there will be no more changes 🥳🥳🥳

[qcjames53]

Hi Aneta. All the changed files look good to me! Thank you for raising #4928 and for changing shells to use $. Super happy with these changes :)

[aneta-petrova]

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

This PR only updates the commands. It does not publish the changes to docs.theforeman.org because I'm only verifying the new commands work, not the procedures as a whole.

The requirement has changed and this PR should now also expose and publish the affected pieces of docs. I'll add some conditionals to make that happen and that will need a new style review.

[aneta-petrova]

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

This PR only updates the commands. It does not publish the changes to docs.theforeman.org because I'm only verifying the new commands work, not the procedures as a whole.

The requirement has changed and this PR should now also expose and publish the affected pieces of docs. I'll add some conditionals to make that happen and that will need a new style review.

After seeing the preview and the conditionals needed to make this happen, there has been a decision to change the scope again and we'll stick to just updating the commands. Exposing the documentation will come later.

[aneta-petrova]

The PR is now back to the state where it has received the acks. #4928 will finish the foremanctl health --fix cleanup by removing the module, this PR only hides it from containerized builds.

[aneta-petrova]

Merged to "master" and cherry-picked:

4f238cc..c46809c 3.19 -> 3.19