Skip to content

Fix image preview tint issue: remove default tint and background from… #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theGoodB0rg merged 1 commit into from
Jan 5, 2026
Merged

Fix image preview tint issue: remove default tint and background from… #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 67 additions & 5 deletions app/src/main/java/com/camerainterceptor/ui/ImagePickerFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import android.net.Uri;
import android.os.Bundle;
import android.provider.MediaStore;
import android.util.Log;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
Expand All @@ -28,7 +29,6 @@
import com.google.android.material.bottomsheet.BottomSheetDialog;
import com.google.android.material.bottomsheet.BottomSheetDialogFragment;
import com.google.android.material.button.MaterialButton;
import com.google.android.material.imageview.ShapeableImageView;
import com.google.android.material.progressindicator.CircularProgressIndicator;

import java.io.File;
Expand All @@ -53,7 +53,7 @@ public class ImagePickerFragment extends BottomSheetDialogFragment {
private static final String TMP_IMAGE_PATH = "/data/local/tmp/camerainterceptor_image.jpg";

// Views
private ShapeableImageView imagePreview;
private ImageView imagePreview;
private FrameLayout placeholderContainer;
private MaterialButton selectButton;
private MaterialButton clearButton;
Expand Down Expand Up @@ -100,6 +100,7 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c
@Override
public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
super.onViewCreated(view, savedInstanceState);
Log.d("ImagePickerDebug", "onViewCreated called");

// Initialize views
imagePreview = view.findViewById(R.id.image_preview);
Expand All @@ -108,13 +109,20 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
clearButton = view.findViewById(R.id.button_clear);
progressIndicator = view.findViewById(R.id.progress_indicator);
statusText = view.findViewById(R.id.status_text);

Log.d("ImagePickerDebug", "imagePreview is " + (imagePreview == null ? "NULL" : "found"));
Log.d("ImagePickerDebug", "placeholderContainer is " + (placeholderContainer == null ? "NULL" : "found"));

// Set up button click listeners
selectButton.setOnClickListener(v -> openGallery());
clearButton.setOnClickListener(v -> clearSelection());

// Load existing preview
loadSavedPreview();
// Load existing preview AFTER view is laid out (fixes 0x0 dimensions issue)
view.post(() -> {
Log.d("ImagePickerDebug", "post(): View is now laid out, loading preview");
Log.d("ImagePickerDebug", "post(): imagePreview dimensions = " + imagePreview.getWidth() + "x" + imagePreview.getHeight());
loadSavedPreview();
});

// Configure bottom sheet behavior
setupBottomSheetBehavior();
Expand Down Expand Up @@ -349,42 +357,96 @@ private void showPlaceholder() {

private void showPreview(File imageFile) {
if (imageFile == null || !imageFile.exists()) {
Log.w("ImagePickerDebug", "showPreview: File is null or doesn't exist");
showPlaceholder();
return;
}

Log.i("ImagePickerDebug", "showPreview: Loading preview from " + imageFile.getAbsolutePath());
Bitmap bitmap = decodeScaledBitmap(imageFile);
if (bitmap != null) {
Log.i("ImagePickerDebug", "showPreview: Bitmap loaded successfully - " + bitmap.getWidth() + "x" + bitmap.getHeight());
Log.i("ImagePickerDebug", "showPreview: imagePreview is " + (imagePreview != null ? "NOT NULL" : "NULL"));
Log.i("ImagePickerDebug", "showPreview: placeholderContainer is " + (placeholderContainer != null ? "NOT NULL" : "NULL"));
if (imagePreview != null) {
Log.i("ImagePickerDebug", "showPreview: Setting bitmap to imagePreview");
Log.i("ImagePickerDebug", "showPreview: imagePreview class = " + imagePreview.getClass().getName());
Log.i("ImagePickerDebug", "showPreview: imagePreview parent = " + (imagePreview.getParent() != null ? imagePreview.getParent().getClass().getName() : "NULL"));
Log.i("ImagePickerDebug", "showPreview: imagePreview width = " + imagePreview.getWidth() + ", height = " + imagePreview.getHeight());
// Clear any previous image first
imagePreview.setImageDrawable(null);
// Ensure no tint or background is interfering
imagePreview.setBackground(null);
imagePreview.setImageTintList(null);
imagePreview.setColorFilter(null);

imagePreview.setImageBitmap(bitmap);
// Verify the drawable was set
android.graphics.drawable.Drawable drawable = imagePreview.getDrawable();
Log.i("ImagePickerDebug", "showPreview: After setImageBitmap, drawable = " + (drawable != null ? drawable.getClass().getName() : "NULL"));
if (drawable != null) {
Log.i("ImagePickerDebug", "showPreview: drawable bounds = " + drawable.getBounds());
Log.i("ImagePickerDebug", "showPreview: drawable intrinsic = " + drawable.getIntrinsicWidth() + "x" + drawable.getIntrinsicHeight());
}
Log.i("ImagePickerDebug", "showPreview: Setting imagePreview VISIBLE");
imagePreview.setVisibility(View.VISIBLE);
Log.i("ImagePickerDebug", "showPreview: imagePreview visibility is now " + imagePreview.getVisibility());
// Force layout refresh
imagePreview.invalidate();
imagePreview.requestLayout();
// Also bring to front just in case
imagePreview.bringToFront();
Log.i("ImagePickerDebug", "showPreview: Called bringToFront()");
} else {
Log.e("ImagePickerDebug", "showPreview: imagePreview is NULL! Cannot display bitmap");
}
if (placeholderContainer != null) {
Log.i("ImagePickerDebug", "showPreview: Setting placeholderContainer GONE");
placeholderContainer.setVisibility(View.GONE);
Log.i("ImagePickerDebug", "showPreview: placeholderContainer visibility is now " + placeholderContainer.getVisibility());
}
if (clearButton != null) {
clearButton.setEnabled(true);
}
} else {
Log.w("ImagePickerDebug", "showPreview: Failed to decode bitmap");
showPlaceholder();
}
}

private Bitmap decodeScaledBitmap(File imageFile) {
try {
Logger.d(TAG, "decodeScaledBitmap: File size = " + imageFile.length() + " bytes");

BitmapFactory.Options bounds = new BitmapFactory.Options();
bounds.inJustDecodeBounds = true;
BitmapFactory.decodeFile(imageFile.getAbsolutePath(), bounds);

Logger.d(TAG, "decodeScaledBitmap: Original size = " + bounds.outWidth + "x" + bounds.outHeight);

if (bounds.outWidth <= 0 || bounds.outHeight <= 0) {
Logger.w(TAG, "decodeScaledBitmap: Invalid image dimensions");
return null;
}

int maxSize = 800;
int sampleSize = 1;
while ((bounds.outHeight / sampleSize) > maxSize || (bounds.outWidth / sampleSize) > maxSize) {
sampleSize *= 2;
}

Logger.d(TAG, "decodeScaledBitmap: Using sample size = " + sampleSize);

BitmapFactory.Options opts = new BitmapFactory.Options();
opts.inSampleSize = sampleSize;
return BitmapFactory.decodeFile(imageFile.getAbsolutePath(), opts);
opts.inPreferredConfig = Bitmap.Config.ARGB_8888;
Bitmap result = BitmapFactory.decodeFile(imageFile.getAbsolutePath(), opts);

if (result == null) {
Logger.w(TAG, "decodeScaledBitmap: BitmapFactory.decodeFile returned null");
}

return result;
} catch (Exception e) {
Logger.w(TAG, "Failed to decode preview: " + e.getMessage());
return null;
Expand Down
30 changes: 16 additions & 14 deletions app/src/main/res/layout/fragment_image_picker.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,29 +51,18 @@
app:cardElevation="0dp"
app:strokeWidth="1dp"
app:strokeColor="?attr/colorOutlineVariant"
app:cardBackgroundColor="?attr/colorSurfaceVariant">
app:cardBackgroundColor="@android:color/transparent">

<FrameLayout
android:layout_width="match_parent"
android:layout_height="wrap_content">

<!-- Image Preview -->
<com.google.android.material.imageview.ShapeableImageView
android:id="@+id/image_preview"
android:layout_width="match_parent"
android:layout_height="@dimen/image_picker_preview_height"
android:scaleType="centerCrop"
android:visibility="gone"
android:contentDescription="@string/image_picker_preview_description"
app:shapeAppearance="@style/ShapeAppearance.CameraInterceptor.ImagePreview"
tools:visibility="visible"
tools:src="@drawable/ic_image" />

<!-- Placeholder Container -->
<!-- Placeholder Container (rendered first, behind image) -->
<FrameLayout
android:id="@+id/placeholder_container"
android:layout_width="match_parent"
android:layout_height="@dimen/image_picker_preview_height"
android:background="@android:color/transparent"
android:visibility="visible"
tools:visibility="gone">

Expand Down Expand Up @@ -104,6 +93,19 @@

</FrameLayout>

<!-- Image Preview (rendered last, on top) -->
<ImageView
android:id="@+id/image_preview"
android:layout_width="match_parent"
android:layout_height="@dimen/image_picker_preview_height"
android:scaleType="centerCrop"
android:visibility="gone"
android:background="@android:color/transparent"
app:tint="@null"
android:contentDescription="@string/image_picker_preview_description"
tools:visibility="visible"
tools:src="@drawable/ic_image" />

<!-- Loading Indicator -->
<com.google.android.material.progressindicator.CircularProgressIndicator
android:id="@+id/progress_indicator"
Expand Down
Loading