submission commit#123
Open
0lcm wants to merge 2 commits into
Open
Conversation
TheCSharpAcademy
requested changes
Apr 20, 2026
Collaborator
There was a problem hiding this comment.
@0lcm Thanks for submitting, it's looking good but I'm not able to add a shift. It's complaining there's no employee id (see picture below) but I never see an option to add an employee. Weirdly I still get a success message. Could you please have a look?
updated the InitialCreate database to allow a nullable EmployeeId on the Shift schema, and added a check within the api after creation to make sure the object was successfully saved to the database, returning a 500 internal error status code if the object was not saved correctly.
Author
|
Hi @TheCSharpAcademy, thank you for taking the time to review my project! There was a previous ef migration that was creating the Shift table with a not null constraint, but I edited the migration, and after updating the database everything is working on my machine. If it still doesn't work, or any other changes need to be made please let me know! 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.