Added my project#167
Open
Ledana wants to merge 3 commits into
Open
Conversation
TheCSharpAcademy
requested changes
May 15, 2026
Collaborator
TheCSharpAcademy
left a comment
There was a problem hiding this comment.
@Ledana Thanks for submitting! At the moment the project doesn't build, I can see these errors:
Could you please fix it so we can start the review?
Author
|
jeez, how could i forget that. fixed! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I followed the tutorial of drinksinfo. i changed console ui to console.spectre and restclient to htttpclient. i created the favourites functionality where the user can see list and delete favourites. when the user is looking at a drink details if that drink is not in favourites database the user is asked if they wish to add the drink to it. i used ef with sql server to store the favourites. i tried to add the view count but first my idea was to only add it in the favourites drinks and the user could see how many times was a drink viewed but it didnt make sense to only have it for the favourites, and to have it for all the drinks first i needed to get all the drinks and save them in my db so i could save the view count, but i couldnt get all drinks couse the free version of the api didnt have a link for all drinks, maybe im wrong, please tell me if there is a simple way to add the count property for all drinks of all categories.
the image part, well the user can click in the drinkthumb link when they see the drink details, in console i dont think there is a way to put images and if that works with azure im still waiting for my credit card couse azure doesnt take my debit one. ive never worked with azure yet.
i know the code can be still cleaner and more organised, but im still getting into the habit of seperating concerns between methods, classes and parent folders as well.
as always, please be brutally honest!